Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753619AbbDAUAn (ORCPT ); Wed, 1 Apr 2015 16:00:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:50283 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752835AbbDAUAl convert rfc822-to-8bit (ORCPT ); Wed, 1 Apr 2015 16:00:41 -0400 Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH 5/7] arm64: dts: qcom: Add 8x16 chipset SPMI PMIC's nodes From: Kumar Gala In-Reply-To: <1427900715-26273-6-git-send-email-ivan.ivanov@linaro.org> Date: Wed, 1 Apr 2015 15:00:36 -0500 Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Russell King , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org Content-Transfer-Encoding: 8BIT Message-Id: <477459F0-90E0-4281-BFFF-F4F73BFCEE85@codeaurora.org> References: <1427900715-26273-1-git-send-email-ivan.ivanov@linaro.org> <1427900715-26273-6-git-send-email-ivan.ivanov@linaro.org> To: "Ivan T. Ivanov" X-Mailer: Apple Mail (2.1878.6) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4680 Lines: 172 On Apr 1, 2015, at 10:05 AM, Ivan T. Ivanov wrote: > PM9816 has 2 SPMI devices per physical package. Add PMIC configuration > nodes including sub-function device nodes and include them in boards, > which are using 8x16 based chipset. > > PM9816 sub-function devices include: > > * GPIO block, with 4 pins > * MPP block, with 4 pins > * Volatage ADC (VADC), with multiple inputs > * Thermal sensor device, which is using on chip VADC > channel report PMIC die temperature. > * Power key device, which is responsible for clean system > reboot or shutdown > * RTC device > > Signed-off-by: Ivan T. Ivanov > --- > arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi | 1 + > arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi | 1 + > arch/arm64/boot/dts/qcom/pm8916.dtsi | 93 +++++++++++++++++++++++++++++++ > 3 files changed, 95 insertions(+) > create mode 100644 arch/arm64/boot/dts/qcom/pm8916.dtsi > > diff --git a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > index 703a4f1..58f0055f 100644 > --- a/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > +++ b/arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi > @@ -12,6 +12,7 @@ > */ > > #include "msm8916.dtsi" > +#include "pm8916.dtsi" > > / { > aliases { > diff --git a/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi b/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi > index bea871b..a1aa0b2 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8916-mtp.dtsi > @@ -12,6 +12,7 @@ > */ > > #include "msm8916.dtsi" > +#include "pm8916.dtsi" > > / { > aliases { > diff --git a/arch/arm64/boot/dts/qcom/pm8916.dtsi b/arch/arm64/boot/dts/qcom/pm8916.dtsi > new file mode 100644 > index 0000000..2a5ad2c > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/pm8916.dtsi > @@ -0,0 +1,93 @@ > +#include > +#include > +#include > + > +&spmi_bus { > + > + usid0: pm8916@0 { > + compatible ="qcom,spmi-pmic"; > + reg = <0x0 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + rtc@6000 { > + compatible = "qcom,pm8941-rtc"; > + reg = <0x6000 0x6100>; > + reg-names = "rtc", "alarm"; > + interrupts = <0x0 0x61 0x1 IRQ_TYPE_EDGE_RISING>; > + }; > + > + pwrkey@800 { > + compatible = "qcom,pm8941-pwrkey"; > + reg = <0x800>; > + interrupts = <0x0 0x8 0 IRQ_TYPE_EDGE_BOTH>; > + debounce = <15625>; > + bias-pull-up; > + }; > + > + pm8916_gpios: gpios@c000 { > + compatible = "qcom,pm8916-gpio"; > + reg = <0xc000 0x400>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <0 0xc0 0 0>, <0 0xc1 0 0>, <0 0xc2 0 0>, <0 0xc3 0 0>; please cleanup level/edge cell values to use defines > + }; > + > + pm8916_mpps: mpps@a000 { > + compatible = "qcom,pm8916-mpp"; > + reg = <0xa000 0x400>; > + gpio-controller; > + #gpio-cells = <2>; > + interrupts = <0 0xa0 0 0>, <0 0xa1 0 0>, <0 0xa2 0 0>, <0 0xa3 0 0>; please cleanup level/edge cell values to use defines > + }; > + > + pm8916_temp: temp-alarm@2400 { > + compatible = "qcom,spmi-temp-alarm"; > + reg = <0x2400 0x100>; > + interrupts = <0 0x24 0 IRQ_TYPE_EDGE_RISING>; > + io-channels = <&pm8916_vadc VADC_DIE_TEMP>; > + io-channel-names = "thermal"; > + #thermal-sensor-cells = <0>; > + }; > + > + pm8916_vadc: vadc@3100 { > + compatible = "qcom,spmi-vadc"; > + reg = <0x3100 0x100>; > + interrupts = <0x0 0x31 0x0 IRQ_TYPE_EDGE_RISING>; > + #address-cells = <1>; > + #size-cells = <0>; > + #io-channel-cells = <1>; > + > + usb_in { > + reg = ; > + qcom,pre-scaling = <1 10>; > + }; > + vph_pwr { > + reg = ; > + qcom,pre-scaling = <1 3>; > + }; > + die_temp { > + reg = ; > + }; > + ref_625mv { > + reg = ; > + }; > + ref_1250v { > + reg = ; > + }; > + ref_gnd { > + reg = ; > + }; > + ref_vdd { > + reg = ; > + }; > + }; > + }; > + > + usid1: pm8916@1 { > + compatible ="qcom,spmi-pmic?; fix whitespace after ?=' > + reg = <0x1 SPMI_USID>; > + #address-cells = <1>; > + #size-cells = <0>; > + }; > +}; > -- > 1.9.1 > -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/