Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752726AbbDBA4G (ORCPT ); Wed, 1 Apr 2015 20:56:06 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:34607 "EHLO mail-pd0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751576AbbDBA4D (ORCPT ); Wed, 1 Apr 2015 20:56:03 -0400 From: Brian Norris To: Zhang Rui , Eduardo Valentin Cc: , , Brian Norris Subject: [PATCH] thermal: user_space: add trip point number to uevent data Date: Wed, 1 Apr 2015 17:55:43 -0700 Message-Id: <1427936143-26508-1-git-send-email-computersforpeace@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 54 A user-space thermal governor does not currently know which trip point caused a uevent to trigger. Let's add this information to the payload. This is just an RFC, because this patch (on its own) is not very useful. The only current caller of the .throttle callback is in thermal_zone_device_update(), which loops over *all* trip points. This seems very counter-intuitive and unhelpful, but maybe I'm just clueless. Signed-off-by: Brian Norris --- drivers/thermal/user_space.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/drivers/thermal/user_space.c b/drivers/thermal/user_space.c index 10adcddc8821..9fc03d3271d6 100644 --- a/drivers/thermal/user_space.c +++ b/drivers/thermal/user_space.c @@ -22,6 +22,8 @@ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ */ +#include +#include #include #include "thermal_core.h" @@ -34,9 +36,18 @@ */ static int notify_user_space(struct thermal_zone_device *tz, int trip) { + char *envp[] = { NULL, NULL }; + + envp[0] = kasprintf(GFP_KERNEL, "TRIPNUM=%u", trip); + if (!envp[0]) + return -ENOMEM; + mutex_lock(&tz->lock); - kobject_uevent(&tz->device.kobj, KOBJ_CHANGE); + kobject_uevent_env(&tz->device.kobj, KOBJ_CHANGE, envp); mutex_unlock(&tz->lock); + + kfree(envp[0]); + return 0; } -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/