Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753050AbbDBDt4 (ORCPT ); Wed, 1 Apr 2015 23:49:56 -0400 Received: from mail4.hitachi.co.jp ([133.145.228.5]:54917 "EHLO mail4.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752036AbbDBDty (ORCPT ); Wed, 1 Apr 2015 23:49:54 -0400 Message-ID: <551CBC5B.8030400@hitachi.com> Date: Thu, 02 Apr 2015 12:49:47 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo CC: Peter Zijlstra , Linux Kernel Mailing List , David Ahern , namhyung@kernel.org, Jiri Olsa , Ingo Molnar Subject: Re: Re: [PATCH perf/core ] perf-probe: Fix to track down unnamed union/structure members References: <20150305153256.GX5187@kernel.org> <20150309021514.4202.36962.stgit@localhost.localdomain> <551BB581.6000002@hitachi.com> <20150401144111.GA4549@kernel.org> In-Reply-To: <20150401144111.GA4549@kernel.org> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2577 Lines: 71 (2015/04/01 23:41), Arnaldo Carvalho de Melo wrote: > Em Wed, Apr 01, 2015 at 06:08:17PM +0900, Masami Hiramatsu escreveu: >> Ping? > > > >>> With this patch, perf probe can access unnamed fields. >>> ----- >>> #./perf probe -nfx ./perf lock__delete ops 'locked_ops=ops->locked.ops' >>> Added new event: >>> probe_perf:lock__delete (on lock__delete in /home/mhiramat/ksrc/linux-3/tools/perf/perf with ops locked_ops=ops->locked.ops) > >>> You can now use it in all perf tools, such as: > >>> perf record -e probe_perf:lock__delete -aR sleep 1 >>> ----- > >>> The original report of this issue is: https://lkml.org/lkml/2015/3/5/431 > > what am I doing wrong? > > [root@ssdandy ~]# perf probe ~acme/bin/perf lock__delete 'locked_ops=ops' > Added new event: > probe_perf:lock__delete (on lock__delete in /home/acme/bin/perf with locked_ops=ops) > > You can now use it in all perf tools, such as: > > perf record -e probe_perf:lock__delete -aR sleep 1 > > [root@ssdandy ~]# perf probe -d probe_perf:* > Removed event: probe_perf:lock__delete > [root@ssdandy ~]# perf probe ~acme/bin/perf lock__delete 'locked_ops=ops->locked' > Semantic error: locked must be referred by '.' > Error: Failed to add events. > [root@ssdandy ~]# perf probe ~acme/bin/perf lock__delete 'locked_ops=ops.locked' > Semantic error: locked must be referred by '->' > Error: Failed to add events. > [root@ssdandy ~]# perf probe ~acme/bin/perf lock__delete 'locked_ops=ops->locked' > Semantic error: locked must be referred by '.' > Error: Failed to add events. > [root@ssdandy ~]# perf probe ~acme/bin/perf lock__delete 'locked_ops=ops->locked.ops' > Semantic error: locked must be referred by '.' > Error: Failed to add events. > [root@ssdandy ~]# Oops, thank you for reporting! I must miss something... Thank you, > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/