Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbbDBDzj (ORCPT ); Wed, 1 Apr 2015 23:55:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52621 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753085AbbDBDze (ORCPT ); Wed, 1 Apr 2015 23:55:34 -0400 Date: Thu, 2 Apr 2015 11:55:32 +0800 From: Fam Zheng To: "Michael S. Tsirkin" Cc: linux-kernel@vger.kernel.org, Bjorn Helgaas , linux-pci@vger.kernel.org, Yinghai Lu , Yijing Wang , Rusty Russell , virtualization@lists.linux-foundation.org Subject: Re: [PATCH v5 06/10] virtio_pci: drop msi_off on probe Message-ID: <20150402035532.GI15412@fam-t430.nay.redhat.com> References: <1427641227-7574-1-git-send-email-mst@redhat.com> <1427641227-7574-7-git-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1427641227-7574-7-git-send-email-mst@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1192 Lines: 35 On Sun, 03/29 17:04, Michael S. Tsirkin wrote: > pci core now disables msi on probe automatically, > drop this from device-specific code. > > Cc: Bjorn Helgaas > Cc: linux-pci@vger.kernel.org > Signed-off-by: Michael S. Tsirkin > --- > drivers/virtio/virtio_pci_common.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/virtio/virtio_pci_common.c b/drivers/virtio/virtio_pci_common.c > index e894eb2..806bb2c 100644 > --- a/drivers/virtio/virtio_pci_common.c > +++ b/drivers/virtio/virtio_pci_common.c > @@ -501,9 +501,6 @@ static int virtio_pci_probe(struct pci_dev *pci_dev, > INIT_LIST_HEAD(&vp_dev->virtqueues); > spin_lock_init(&vp_dev->lock); > > - /* Disable MSI/MSIX to bring device to a known good state. */ > - pci_msi_off(pci_dev); > - > /* enable the device */ > rc = pci_enable_device(pci_dev); > if (rc) > -- > MST > Reviewed-by: Fam Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/