Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751260AbbDBEaH (ORCPT ); Thu, 2 Apr 2015 00:30:07 -0400 Received: from helcar.hengli.com.au ([209.40.204.226]:37824 "EHLO helcar.hengli.com.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711AbbDBEaG (ORCPT ); Thu, 2 Apr 2015 00:30:06 -0400 Date: Thu, 2 Apr 2015 12:29:50 +0800 From: Herbert Xu To: Fengguang Wu Cc: LKP , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Graf Subject: Re: [rhashtable] [ INFO: suspicious RCU usage. ] Message-ID: <20150402042950.GA5643@gondor.apana.org.au> References: <20150402005211.GC12979@wfg-t540p.sh.intel.com> <20150402035810.GA5408@gondor.apana.org.au> <20150402041135.GA22514@wfg-t540p.sh.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150402041135.GA22514@wfg-t540p.sh.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1759 Lines: 47 On Thu, Apr 02, 2015 at 12:11:35PM +0800, Fengguang Wu wrote: > > Yes it is contained in next-20150401 which is bad: > > # extra tests on tree/branch next/master > git bisect bad e954104e2b634b42811dad8d502cbf240f206df2 # 21:22 0- 60 Add linux-next specific files for 20150401 > > The dmesg there is > > [ 1.149409] test_firmware: interface ready > [ 1.150293] Running resizable hashtable tests... > [ 1.151209] Adding 2048 keys > [ 1.152069] ------------[ cut here ]------------ > [ 1.152978] WARNING: CPU: 0 PID: 1 at lib/rhashtable.c:409 rhashtable_insert_rehash+0x9d/0x1d0() I see. This is actually a completely different problem. ---8<--- test_rhashtable: Remove bogus max_size setting Now that resizing is completely automatic, we need to remove the max_size setting or the test will fail. Reported-by: Fengguang Wu Signed-off-by: Herbert Xu diff --git a/lib/test_rhashtable.c b/lib/test_rhashtable.c index a42a0d4..b295754 100644 --- a/lib/test_rhashtable.c +++ b/lib/test_rhashtable.c @@ -44,7 +44,6 @@ static const struct rhashtable_params test_rht_params = { .key_offset = offsetof(struct test_obj, value), .key_len = sizeof(int), .hashfn = jhash, - .max_size = 2, /* we expand/shrink manually here */ .nulls_base = (3U << RHT_BASE_SHIFT), }; -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/