Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751751AbbDBEhk (ORCPT ); Thu, 2 Apr 2015 00:37:40 -0400 Received: from mail.skyhub.de ([78.46.96.112]:58029 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbbDBEhi (ORCPT ); Thu, 2 Apr 2015 00:37:38 -0400 Date: Thu, 2 Apr 2015 06:35:39 +0200 From: Borislav Petkov To: Mark Einon Cc: x86@kernel.org, tglx@linutronix.de, mingo@kernel.org, linux-kernel@vger.kernel.org, hpa@zytor.com, stuart.r.anderson@intel.com Subject: Re: [PATCH v3] x86, earlyprintk: Fix two 'defined but not used' compile warnings Message-ID: <20150402043538.GB3483@pd.tnic> References: <1427839640-13584-1-git-send-email-mark.einon@gmail.com> <1427923924-22653-1-git-send-email-mark.einon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1427923924-22653-1-git-send-email-mark.einon@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1439 Lines: 36 On Wed, Apr 01, 2015 at 10:32:04PM +0100, Mark Einon wrote: > Two static functions are only used if CONFIG_PCI is defined,so only build them > if this is the case. Fixes the build warnings: > > arch/x86/kernel/early_printk.c:98:13: warning: ‘mem32_serial_out’ defined but not used [-Wunused-function] > static void mem32_serial_out(unsigned long addr, int offset, int value) > ^ > arch/x86/kernel/early_printk.c:105:21: warning: ‘mem32_serial_in’ defined but not used [-Wunused-function] > static unsigned int mem32_serial_in(unsigned long addr, int offset) > ^ > > Also convert a few related instances of uintXX_t to kernel specific uXX defines. > > Signed-off-by: Mark Einon > --- > v2 - Move code to another #ifdef instead of creating a new ifdef pair after > comment by Borislav Petkov . > > v3 - Fixed commit errors from v2, changed some uintXX_t data types to equivalent uXX. > > arch/x86/kernel/early_printk.c | 32 ++++++++++++++++---------------- > 1 file changed, 16 insertions(+), 16 deletions(-) Applied, thanks. -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/