Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751925AbbDBF6O (ORCPT ); Thu, 2 Apr 2015 01:58:14 -0400 Received: from mail9.hitachi.co.jp ([133.145.228.44]:39287 "EHLO mail9.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbDBF6L (ORCPT ); Thu, 2 Apr 2015 01:58:11 -0400 Message-ID: <551CDA6C.50106@hitachi.com> Date: Thu, 02 Apr 2015 14:58:04 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim CC: Shuah Khan , Steven Rostedt , LKML , =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , Michael Ellerman , Dave Jones , Luis Henriques Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly References: <1427948663-25048-1-git-send-email-namhyung@kernel.org> <1427949253-26883-1-git-send-email-namhyung@kernel.org> In-Reply-To: <1427949253-26883-1-git-send-email-namhyung@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5192 Lines: 179 (2015/04/02 13:34), Namhyung Kim wrote: > The usleep is only provided on distros from Redhat so running ftracetest > on other distro resulted in failures due to the missing usleep. > > The reason of using [u]sleep in the test was to generate (scheduler) > events. It can be done various ways like this: > > yield() { ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1; } Nice hack! :) Acked-by: Masami Hiramatsu > > Reported-by: Michael Ellerman > Reported-by: Dave Jones > Reported-by: Luis Henriques > Based-on-patch-by: Pádraig Brady > CC: Masami Hiramatsu > Signed-off-by: Namhyung Kim > --- > fix a typo of pinc > > tools/testing/selftests/ftrace/test.d/event/event-enable.tc | 13 ++++++++++--- > .../selftests/ftrace/test.d/event/subsystem-enable.tc | 13 ++++++++++--- > .../selftests/ftrace/test.d/event/toplevel-enable.tc | 13 +++++++++++++ > 3 files changed, 33 insertions(+), 6 deletions(-) > > diff --git a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > index 668616d9bb03..c40c139aaf2b 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/event-enable.tc > @@ -12,6 +12,10 @@ fail() { #msg > exit -1 > } > > +yield() { > + ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1 > +} > + > if [ ! -f set_event -o ! -d events/sched ]; then > echo "event tracing is not supported" > exit_unsupported > @@ -21,7 +25,8 @@ reset_tracer > do_reset > > echo 'sched:sched_switch' > set_event > -usleep 1 > + > +yield > > count=`cat trace | grep sched_switch | wc -l` > if [ $count -eq 0 ]; then > @@ -31,7 +36,8 @@ fi > do_reset > > echo 1 > events/sched/sched_switch/enable > -usleep 1 > + > +yield > > count=`cat trace | grep sched_switch | wc -l` > if [ $count -eq 0 ]; then > @@ -41,7 +47,8 @@ fi > do_reset > > echo 0 > events/sched/sched_switch/enable > -usleep 1 > + > +yield > > count=`cat trace | grep sched_switch | wc -l` > if [ $count -ne 0 ]; then > diff --git a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > index 655c415b6e7f..cbd98b71ee8a 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/subsystem-enable.tc > @@ -12,6 +12,10 @@ fail() { #msg > exit -1 > } > > +yield() { > + ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1 > +} > + > if [ ! -f set_event -o ! -d events/sched ]; then > echo "event tracing is not supported" > exit_unsupported > @@ -21,7 +25,8 @@ reset_tracer > do_reset > > echo 'sched:*' > set_event > -usleep 1 > + > +yield > > count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > if [ $count -lt 3 ]; then > @@ -31,7 +36,8 @@ fi > do_reset > > echo 1 > events/sched/enable > -usleep 1 > + > +yield > > count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > if [ $count -lt 3 ]; then > @@ -41,7 +47,8 @@ fi > do_reset > > echo 0 > events/sched/enable > -usleep 1 > + > +yield > > count=`cat trace | grep -v ^# | awk '{ print $5 }' | sort -u | wc -l` > if [ $count -ne 0 ]; then > diff --git a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > index 480845774007..65e2ab666611 100644 > --- a/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > +++ b/tools/testing/selftests/ftrace/test.d/event/toplevel-enable.tc > @@ -12,6 +12,10 @@ fail() { #msg > exit -1 > } > > +yield() { > + ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1 > +} > + > if [ ! -f available_events -o ! -f set_event -o ! -d events ]; then > echo "event tracing is not supported" > exit_unsupported > @@ -21,6 +25,9 @@ reset_tracer > do_reset > > echo '*:*' > set_event > + > +yield > + > count=`cat trace | grep -v ^# | wc -l` > if [ $count -eq 0 ]; then > fail "none of events are recorded" > @@ -29,6 +36,9 @@ fi > do_reset > > echo 1 > events/enable > + > +yield > + > count=`cat trace | grep -v ^# | wc -l` > if [ $count -eq 0 ]; then > fail "none of events are recorded" > @@ -37,6 +47,9 @@ fi > do_reset > > echo 0 > events/enable > + > +yield > + > count=`cat trace | grep -v ^# | wc -l` > if [ $count -ne 0 ]; then > fail "any of events should not be recorded" > -- Masami HIRAMATSU Linux Technology Research Center, System Productivity Research Dept. Center for Technology Innovation - Systems Engineering Hitachi, Ltd., Research & Development Group E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/