Date: Thu, 2 Apr 2015 17:12:31 +0900
From: Namhyung Kim <namhyung@kernel.org>
To: Wang Nan <wangnan0@huawei.com>
Cc: acme@kernel.org, jolsa@kernel.org, mingo@redhat.com, lizefan@huawei.com,
        pi3orama@163.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf: annotate: make it respect -i option.
Message-ID: <20150402081231.GC23913@sejong>
References: <1427954692-105642-1-git-send-email-wangnan0@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <1427954692-105642-1-git-send-email-wangnan0@huawei.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 994
Lines: 27

On Thu, Apr 02, 2015 at 06:04:52AM +0000, Wang Nan wrote:
> There is a bug in perf annotate that it doesn't respect user provided
> '-i'/'--input' option:
> 
>  # perf record ls
>    [ perf record: Woken up 1 times to write data ]
>    [ perf record: Captured and wrote 0.001 MB perf.data (8 samples) ]
>  # mv ./perf.data ./perf.data.new
>  # perf annotate -i ./perf.data.new  --stdio
>    failed to open perf.data: No such file or directory  (try 'perf record' first)
> 
> This patch fix it by setting file path after option parsing, like
> what 'perf report' does.
> 
> Signed-off-by: Wang Nan <wangnan0@huawei.com>

I guess other commands are also suffered from this bug.. anyway,

Acked-by: Namhyung Kim <namhyung@kernel.org>

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/