Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753273AbbDBJH2 (ORCPT ); Thu, 2 Apr 2015 05:07:28 -0400 Received: from mga03.intel.com ([134.134.136.65]:50529 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752670AbbDBJHZ (ORCPT ); Thu, 2 Apr 2015 05:07:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,509,1422950400"; d="scan'208";a="674238084" Date: Thu, 2 Apr 2015 12:07:02 +0300 From: Mika Westerberg To: Feng Kan Cc: patches , Jassi Brar , "linux-kernel@vger.kernel.org" , "linux-acpi@vger.kernel.org" Subject: Re: [PATCH] mailbox: add ACPI support for mailbox framework Message-ID: <20150402090702.GD17830@lahna.fi.intel.com> References: <1427836680-13008-1-git-send-email-fkan@apm.com> <20150401074553.GV1524@lahna.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2072 Lines: 60 On Wed, Apr 01, 2015 at 10:01:45AM -0700, Feng Kan wrote: > On Wed, Apr 1, 2015 at 12:45 AM, Mika Westerberg > wrote: > > On Tue, Mar 31, 2015 at 02:18:00PM -0700, Feng Kan wrote: > >> This will add support for ACPI parsing of the mboxes attribute > >> when booting with ACPI table. The client will have a attribute > >> mimic the dts call "mboxes". In the ACPI case, the client will > >> mark "mboxes" with the ACPI HID of the mbox it wishes to use. > >> > >> Name (_DSD, Package () { > >> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > >> Package () { > >> Package (2) {"mboxes", "ACPIHID"}, > >> } > >> }) > > > > Instead of this, why not match against the DT compatible property? > > > > Name (_HID, "PRP0001") > > > > Name (_DSD, Package () { > > ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), > > Package () { > > Package (2) {"compatible", "your-dt-compatible-string"}, > > } > > }) > I think my description was not clear enough. The _DSD section is not > meant to identify the mailbox driver, but used by the acpi node that will > request the mailbox channel. The dts version would be as below. > > mailbox: { > } > > user-mbox: { > mboxes: <&mailbox 0> > } > > The mboxes attribute in the user of the mbox has to specify the HID of the > mbox in order to retrieve channel pointer. Okay, then I think you can use reference instead of _HID, like // The mailbox device Device (MLBX) { } // User-mbox device Device (USBX) { Name (_DSD, Package () { ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"), Package () { Package () {"mboxes", Package () {^^MLBX, 0}}), } }) } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/