Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753053AbbDBLVT (ORCPT ); Thu, 2 Apr 2015 07:21:19 -0400 Received: from mail.skyhub.de ([78.46.96.112]:37949 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752745AbbDBLVQ (ORCPT ); Thu, 2 Apr 2015 07:21:16 -0400 Date: Thu, 2 Apr 2015 13:19:15 +0200 From: Borislav Petkov To: Ingo Molnar Cc: LKML , Kees Cook , x86-ml , "H. Peter Anvin" , Thomas Gleixner Subject: Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper Message-ID: <20150402111915.GC3483@pd.tnic> References: <1427885970-14240-1-git-send-email-bp@alien8.de> <20150402040352.GA3483@pd.tnic> <20150402110713.GA29311@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20150402110713.GA29311@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 960 Lines: 30 On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote: > So doesn't a 'nokaslr' boot option still make sense, to be able to > debug KASLR failures and such? That's still parsed in arch/x86/boot/compressed/aslr.c > > + if (kaslr_enabled()) > > + pr_emerg("Kernel Offset: 0x%lx from 0x%lx (relocation range: 0x%lx-0x%lx)\n", > > + (unsigned long)&_text - __START_KERNEL, > > + __START_KERNEL, > > + __START_KERNEL_map, > > + MODULES_VADDR-1); > > + else > > + pr_emerg("Kernel Offset: disabled\n"); > > Nit: curly braces for multi-line statements and so. I guess by multi-line you mean multiple source lines... -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/