Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753238AbbDBLWO (ORCPT ); Thu, 2 Apr 2015 07:22:14 -0400 Received: from demumfd001.nsn-inter.net ([93.183.12.32]:34405 "EHLO demumfd001.nsn-inter.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753052AbbDBLWM (ORCPT ); Thu, 2 Apr 2015 07:22:12 -0400 Message-ID: <551D265C.40703@nokia.com> Date: Thu, 02 Apr 2015 13:22:04 +0200 From: Alexander Sverdlin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org CC: Ioan Nicu , Peter Korsgaard , Wolfram Sang , Mathias Rulf Subject: Re: [PATCH v2] i2c: i2c-mux-gpio: remove error messages for probe deferrals References: <20150330130338.GB5933@ulegcpding.emea.nsn-net.net> In-Reply-To: <20150330130338.GB5933@ulegcpding.emea.nsn-net.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-purgate-type: clean X-purgate-Ad: Categorized by eleven eXpurgate (R) http://www.eleven.de X-purgate: clean X-purgate: This mail is considered clean (visit http://www.eleven.de for further information) X-purgate-size: 1578 X-purgate-ID: 151667::1427973727-0000328B-20785D86/0/0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1774 Lines: 54 On 30/03/15 15:03, Ioan Nicu wrote: > Probe deferral is not an error case. It happens only when > the necessary dependencies are not there yet. > > The driver core is already printing a message when a driver > requests probe deferral, so this can be traced in the logs > without these error prints. > > This patch removes the error messages for these deferral cases. > > Signed-off-by: Ionut Nicu Acked-by: Alexander Sverdlin > --- > drivers/i2c/muxes/i2c-mux-gpio.c | 10 +++------- > 1 files changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/i2c/muxes/i2c-mux-gpio.c b/drivers/i2c/muxes/i2c-mux-gpio.c > index f5798eb..70db992 100644 > --- a/drivers/i2c/muxes/i2c-mux-gpio.c > +++ b/drivers/i2c/muxes/i2c-mux-gpio.c > @@ -76,10 +76,9 @@ static int i2c_mux_gpio_probe_dt(struct gpiomux *mux, > return -ENODEV; > } > adapter = of_find_i2c_adapter_by_node(adapter_np); > - if (!adapter) { > - dev_err(&pdev->dev, "Cannot find parent bus\n"); > + if (!adapter) > return -EPROBE_DEFER; > - } > + > mux->data.parent = i2c_adapter_id(adapter); > put_device(&adapter->dev); > > @@ -177,11 +176,8 @@ static int i2c_mux_gpio_probe(struct platform_device *pdev) > } > > parent = i2c_get_adapter(mux->data.parent); > - if (!parent) { > - dev_err(&pdev->dev, "Parent adapter (%d) not found\n", > - mux->data.parent); > + if (!parent) > return -EPROBE_DEFER; > - } > > mux->parent = parent; > mux->gpio_base = gpio_base; > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/