Date: Thu, 2 Apr 2015 13:29:30 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Borislav Petkov <bp@alien8.de>
Cc: LKML <linux-kernel@vger.kernel.org>, Kees Cook <keescook@chromium.org>,
        x86-ml <x86@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v1.1] x86/mm/ASLR: Propagate ASLR status to kernel proper
Message-ID: <20150402112930.GA14370@gmail.com>
References: <1427885970-14240-1-git-send-email-bp@alien8.de>
 <20150402040352.GA3483@pd.tnic>
 <20150402110713.GA29311@gmail.com>
 <20150402111915.GC3483@pd.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150402111915.GC3483@pd.tnic>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1028
Lines: 35


* Borislav Petkov <bp@alien8.de> wrote:

> On Thu, Apr 02, 2015 at 01:07:13PM +0200, Ingo Molnar wrote:
> > So doesn't a 'nokaslr' boot option still make sense, to be able to 
> > debug KASLR failures and such?
> 
> That's still parsed in arch/x86/boot/compressed/aslr.c

So was this duplication dead code in essence?

> 
> > > +	if (kaslr_enabled())
> > > +		pr_emerg("Kernel Offset: 0x%lx from 0x%lx (relocation range: 0x%lx-0x%lx)\n",
> > > +			 (unsigned long)&_text - __START_KERNEL,
> > > +			 __START_KERNEL,
> > > +			 __START_KERNEL_map,
> > > +			 MODULES_VADDR-1);
> > > +	else
> > > +		pr_emerg("Kernel Offset: disabled\n");
> > 
> > Nit: curly braces for multi-line statements and so.
> 
> I guess by multi-line you mean multiple source lines...

Yeah.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/