Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752477AbbDBLpw (ORCPT ); Thu, 2 Apr 2015 07:45:52 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:36022 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752218AbbDBLpt (ORCPT ); Thu, 2 Apr 2015 07:45:49 -0400 X-IronPort-AV: E=Sophos;i="5.11,510,1422921600"; d="scan'208";a="250812883" Message-ID: <551D2BE9.2000002@citrix.com> Date: Thu, 2 Apr 2015 13:45:45 +0200 From: =?windows-1252?Q?Roger_Pau_Monn=E9?= User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: "Chentao (Boby)" , , CC: , , , Subject: Re: [PATCH v2] xen-blkback: define pr_fmt macro to avoid the duplication of DRV_PFX References: <1427900662-25419-1-git-send-email-boby.chen@huawei.com> <551C9C42.6020604@huawei.com> In-Reply-To: <551C9C42.6020604@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 33 El 02/04/15 a les 3.32, Chentao (Boby) ha escrit: > > > On 2015/4/1 23:04, Tao Chen wrote: >> Define pr_fmt macro with {xen-blkback: } prefix, then remove all use >> of DRV_PFX in the pr sentences. Replace all DPRINTK with pr sentences, >> and get rid of DPRINTK macro. It will simplify the code. >> >> And if the pr sentences miss a \n, add it in the end. If the DPRINTK >> sentences have redundant \n, remove it. It will format the code. >> > > I'm sorry, I made a mistake in this patch log. It must be changed as below. > > And if the pr sentences miss a \n, add it in the end. It will format the > code. > > I apologize for the disturb of wrong patch log. Very looking forward > to your reply. > >> These all make the readability of the code become better. >> >> Signed-off-by: Tao Chen Thanks, with the commit message amended: Acked-by: Roger Pau Monn? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/