Date: Thu, 2 Apr 2015 09:38:27 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: Namhyung Kim <namhyung@kernel.org>, Shuah Khan <shuahkh@osg.samsung.com>,
        LKML <linux-kernel@vger.kernel.org>,
        =?UTF-8?B?UMOhZHJhaWc=?= Brady <P@draigBrady.com>,
        Michael Ellerman <mpe@ellerman.id.au>,
        Dave Jones <davej@codemonkey.org.uk>,
        Luis Henriques <luis.henriques@canonical.com>
Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly
Message-ID: <20150402093827.617192f0@gandalf.local.home>
In-Reply-To: <551CDA6C.50106@hitachi.com>
References: <1427948663-25048-1-git-send-email-namhyung@kernel.org>
	<1427949253-26883-1-git-send-email-namhyung@kernel.org>
	<551CDA6C.50106@hitachi.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1275
Lines: 37

On Thu, 02 Apr 2015 14:58:04 +0900
Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:

> (2015/04/02 13:34), Namhyung Kim wrote:
> > The usleep is only provided on distros from Redhat so running ftracetest
> > on other distro resulted in failures due to the missing usleep.
> > 
> > The reason of using [u]sleep in the test was to generate (scheduler)
> > events.  It can be done various ways like this:
> > 
> > yield() {  ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1; }
> 
> Nice hack! :)

Yep, it was Pádraig Brady's idea.

> 
> Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>

Acked-by: Steven Rostedt <rostedt@goodmis.org>

-- Steve

> 
> > 
> > Reported-by: Michael Ellerman <mpe@ellerman.id.au>
> > Reported-by: Dave Jones <davej@codemonkey.org.uk>
> > Reported-by: Luis Henriques <luis.henriques@canonical.com>
> > Based-on-patch-by: Pádraig Brady <P@draigBrady.com>
> > CC: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
> > Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> > ---
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/