Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753559AbbDBOUP (ORCPT ); Thu, 2 Apr 2015 10:20:15 -0400 Received: from lists.s-osg.org ([54.187.51.154]:33244 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752974AbbDBOUL (ORCPT ); Thu, 2 Apr 2015 10:20:11 -0400 Message-ID: <551D5019.9010806@osg.samsung.com> Date: Thu, 02 Apr 2015 08:20:09 -0600 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: Steven Rostedt , Masami Hiramatsu CC: Namhyung Kim , LKML , =?UTF-8?B?UMOhZHJhaWcgQnJhZHk=?= , Michael Ellerman , Dave Jones , Luis Henriques , Shuah Khan Subject: Re: [PATCH v2.1] ftracetest: Do not use usleep directly References: <1427948663-25048-1-git-send-email-namhyung@kernel.org> <1427949253-26883-1-git-send-email-namhyung@kernel.org> <551CDA6C.50106@hitachi.com> <20150402093827.617192f0@gandalf.local.home> In-Reply-To: <20150402093827.617192f0@gandalf.local.home> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 50 On 04/02/2015 07:38 AM, Steven Rostedt wrote: > On Thu, 02 Apr 2015 14:58:04 +0900 > Masami Hiramatsu wrote: > >> (2015/04/02 13:34), Namhyung Kim wrote: >>> The usleep is only provided on distros from Redhat so running ftracetest >>> on other distro resulted in failures due to the missing usleep. >>> >>> The reason of using [u]sleep in the test was to generate (scheduler) >>> events. It can be done various ways like this: >>> >>> yield() { ping localhost -c 1 || sleep .001 || usleep 1 || sleep 1; } >> >> Nice hack! :) > > Yep, it was Pádraig Brady's idea. > >> >> Acked-by: Masami Hiramatsu > > Acked-by: Steven Rostedt > > -- Steve > >> >>> >>> Reported-by: Michael Ellerman >>> Reported-by: Dave Jones >>> Reported-by: Luis Henriques >>> Based-on-patch-by: Pádraig Brady Is this standard? checkpatch complained as non-standard. I am seeing some patches posted with Based-on-patch-by Anyway, I have this patch tagged for 4.1-rc2 thanks, -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/