Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753305AbbDBPjx (ORCPT ); Thu, 2 Apr 2015 11:39:53 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:36632 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752536AbbDBPjv (ORCPT ); Thu, 2 Apr 2015 11:39:51 -0400 MIME-Version: 1.0 In-Reply-To: <551D60BE.1070101@plexistor.com> References: <1427872339-6688-1-git-send-email-hch@lst.de> <551D60BE.1070101@plexistor.com> Date: Thu, 2 Apr 2015 08:39:50 -0700 Message-ID: Subject: Re: [Linux-nvdimm] [PATCH] pmem: Add prints at module load and unload From: Dan Williams To: Boaz Harrosh Cc: Christoph Hellwig , linux-nvdimm , linux-fsdevel , "linux-kernel@vger.kernel.org" , X86 ML , Jens Axboe Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2121 Lines: 61 On Thu, Apr 2, 2015 at 8:31 AM, Boaz Harrosh wrote: > Hi Christoph, Ingo > > Please consider this small patch below just a small print at module > load/unload so to know at user systems how things progressed. > As it is now, we know nothing. For any other disk kind we have two > tuns of prints. > > --- > From: Boaz Harrosh > Date: Thu, 2 Apr 2015 16:43:48 +0300 > Subject: [PATCH] pmem: Add prints at module load and unload > > When debugging people's systems it is helpful > to see what went on. The load and unload of pmem is > an important event. > > The importance is the number of loaded devices and > error status. The exact device's addresses created > we can see from the other prints at e820 so no need > to duplicate this information. > > While at it fix up a small issue with rw flags. Separate patch for fixes please. > > Signed-off-by: Boaz Harrosh > --- > drivers/block/pmem.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/block/pmem.c b/drivers/block/pmem.c > index 988f384..3f15fbc 100644 > --- a/drivers/block/pmem.c > +++ b/drivers/block/pmem.c > @@ -91,8 +91,9 @@ static int pmem_rw_page(struct block_device *bdev, sector_t sector, > { > struct pmem_device *pmem = bdev->bd_disk->private_data; > > + rw &= WRITE; > pmem_do_bvec(pmem, page, PAGE_CACHE_SIZE, 0, rw, sector); > - page_endio(page, rw & WRITE, 0); > + page_endio(page, rw, 0); > > return 0; > } > @@ -248,6 +249,9 @@ static int __init pmem_init(void) > error = platform_driver_register(&pmem_driver); > if (error) > unregister_blkdev(pmem_major, "pmem"); > + > + pr_info("pmem: init %d devices => %d\n", > + atomic_read(&pmem_index), error); If anything I think these should be dev_dbg(). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/