Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753067AbbDBRXz (ORCPT ); Thu, 2 Apr 2015 13:23:55 -0400 Received: from mail-ie0-f177.google.com ([209.85.223.177]:36447 "EHLO mail-ie0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750747AbbDBRXx (ORCPT ); Thu, 2 Apr 2015 13:23:53 -0400 MIME-Version: 1.0 In-Reply-To: <551D6EEA.6050704@hurleysoftware.com> References: <1425932842-21812-1-git-send-email-peter@hurleysoftware.com> <1425932842-21812-12-git-send-email-peter@hurleysoftware.com> <551CB5DF.1010108@hurleysoftware.com> <551D6EEA.6050704@hurleysoftware.com> Date: Thu, 2 Apr 2015 10:23:52 -0700 X-Google-Sender-Auth: xJhdPx-_mCeRqhdgSpnVUb0HipY Message-ID: Subject: Re: [PATCH v3 -next 11/11] serial: 8250_early: Remove setup_early_serial8250_console() From: Yinghai Lu To: Peter Hurley Cc: Greg Kroah-Hartman , Andrew Morton , Jiri Slaby , Rob Herring , Linux Kernel Mailing List , "linux-serial@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2134 Lines: 61 On Thu, Apr 2, 2015 at 9:31 AM, Peter Hurley wrote: > Would you please try the patch below instead? > > --- >% --- > From: Peter Hurley > Subject: [PATCH] earlycon: Fix __earlycon_table stride > > Signed-off-by: Peter Hurley > --- > include/asm-generic/vmlinux.lds.h | 2 +- > include/linux/serial_core.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > index 7b0ef49..2e11f31 100644 > --- a/include/asm-generic/vmlinux.lds.h > +++ b/include/asm-generic/vmlinux.lds.h > @@ -151,7 +151,7 @@ > #endif > > #ifdef CONFIG_SERIAL_EARLYCON > -#define EARLYCON_TABLE() . = ALIGN(8); \ > +#define EARLYCON_TABLE() STRUCT_ALIGN(); \ > VMLINUX_SYMBOL(__earlycon_table) = .; \ > *(__earlycon_table) \ > *(__earlycon_table_end) > diff --git a/include/linux/serial_core.h b/include/linux/serial_core.h > index 34de168..025dad9 100644 > --- a/include/linux/serial_core.h > +++ b/include/linux/serial_core.h > @@ -342,7 +342,7 @@ struct earlycon_device { > struct earlycon_id { > char name[16]; > int (*setup)(struct earlycon_device *, const char *options); > -}; > +} __aligned(32); > > extern int setup_earlycon(char *buf); > extern int of_setup_earlycon(unsigned long addr, > -- Great. that works, and less lines change than my version. ffffffff832049a0 T __earlycon_table ffffffff832049a0 t __earlycon_uart ffffffff832049c0 t __earlycon_uart8250 ffffffff832049e0 t __earlycon_table_sentinel [ 0.000000] bootconsole [uart0] enabled [ 0.000000] uart8250 probed_baud_rate: 115200 [ 0.000000] size of earlycon_id: 0x20 Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/