Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753208AbbDBRbx (ORCPT ); Thu, 2 Apr 2015 13:31:53 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:34291 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753006AbbDBRbw (ORCPT ); Thu, 2 Apr 2015 13:31:52 -0400 MIME-Version: 1.0 In-Reply-To: <551C6A48.9060805@canonical.com> References: <20150331031536.GA9303@canonical.com> <20150331222327.GA12512@canonical.com> <20150401124336.GB12841@gmail.com> <20150401161047.GD12730@canonical.com> <551C6A48.9060805@canonical.com> Date: Thu, 2 Apr 2015 10:31:50 -0700 X-Google-Sender-Auth: vYuldaVE9qgbtOVffygHdZuKr7U Message-ID: Subject: Re: smp_call_function_single lockups From: Linus Torvalds To: Chris J Arges Cc: Ingo Molnar , Rafael David Tinoco , Peter Anvin , Jiang Liu , Peter Zijlstra , LKML , Jens Axboe , Frederic Weisbecker , Gema Gomez , "the arch/x86 maintainers" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1259 Lines: 26 On Wed, Apr 1, 2015 at 2:59 PM, Chris J Arges wrote: > > It is worthwhile to do a 'bisect' to see where on average it takes > longer to reproduce? Perhaps it will point to a relevant change, or it > may be completely useless. It's likely to be an exercise in futility. "git bisect" is realyl bad at "gray area" things, and when it's a question of "it takes hours or days to reproduce", it's almost certainly not worth it. Not unless there is some really clear cut-off that we can believably say "this causes it to get much slower". And in this case, I don't think it's that clear-cut. Judging by DaveJ's attempts at bisecting things, the timing just changes. And the differences might be due to entirely unrelated changes like cacheline alignment etc. So unless we find a real clear signature of the bug (I was hoping that the ISR bit would be that sign), I don't think trying to bisect it based on how quickly you can reproduce things is worthwhile. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/