Message-ID: <1427996385.31965.1.camel@fourier>
Subject: Re: [PATCH 3.13.y-ckt 056/143] usb: musb: add omap-control
 dependency
From: Kamal Mostafa <kamal@canonical.com>
To: Luis Henriques <luis.henriques@canonical.com>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        kernel-team@lists.ubuntu.com, Felipe Balbi <balbi@ti.com>,
        Arnd Bergmann <arnd@arndb.de>
Date: Thu, 02 Apr 2015 10:39:45 -0700
In-Reply-To: <20150401093752.GB20394@charon.olymp>
References: <1427831308-1854-1-git-send-email-kamal@canonical.com>
	 <1427831308-1854-57-git-send-email-kamal@canonical.com>
	 <20150401093752.GB20394@charon.olymp>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3100
Lines: 83

On Wed, 2015-04-01 at 10:37 +0100, Luis Henriques wrote:
> On Tue, Mar 31, 2015 at 12:47:01PM -0700, Kamal Mostafa wrote:
> > 3.13.11-ckt18 -stable review patch.  If anyone has any objections, please let me know.
> >
> 
> Arnd reported a regression caused by this patch.  It seems to be fixed
> by commit 1c390eb360c3 ("usb: musb: fix Kconfig regression"), also
> tagged for stable.  However, it looks like this patch was actually
> dropped from all the stable trees as Arnd also pointed out that the
> original problem was relatively harmless.

Ok, I'll drop it from 3.13-stable as well then.  Thanks Luis and Arnd.

 -Kamal


> Cheers,
> --
> Luís
> 
> > ------------------
> > 
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > commit fbba7db3990cb707ff91cd6507d53a0a730afe97 upstream.
> > 
> > The omap musb front-end calls into the phy driver directly
> > instead of using a generic phy interface, which causes a link
> > error when the specific driver is not built-in:
> > 
> > drivers/built-in.o: In function `omap2430_musb_disable':
> > usb/musb/omap2430.c:480: undefined reference to `omap_control_usb_set_mode'
> > drivers/built-in.o: In function `omap2430_musb_enable':
> > usb/musb/omap2430.c:466: undefined reference to `omap_control_usb_set_mode'
> > usb/musb/omap2430.c:447: undefined reference to `omap_control_usb_set_mode'
> > drivers/built-in.o: In function `omap_musb_set_mailbox':
> > usb/musb/omap2430.c:273: undefined reference to `omap_control_usb_set_mode'
> > usb/musb/omap2430.c:304: undefined reference to `omap_control_usb_set_mode'
> > drivers/built-in.o:(.debug_addr+0xbd9e0): more undefined references to `omap_control_usb_set_mode' follow
> > 
> > This adds an explicit dependency.
> > 
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > Fixes: ca784be36cc725 ("usb: start using the control module driver")
> > Signed-off-by: Felipe Balbi <balbi@ti.com>
> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> > ---
> >  drivers/usb/musb/Kconfig | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> > index a70f46f..ddcbcdd 100644
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -74,7 +74,7 @@ config USB_MUSB_TUSB6010
> >  
> >  config USB_MUSB_OMAP2PLUS
> >  	tristate "OMAP2430 and onwards"
> > -	depends on ARCH_OMAP2PLUS && USB
> > +	depends on ARCH_OMAP2PLUS && USB && OMAP_CONTROL_PHY
> >  	select GENERIC_PHY
> >  
> >  config USB_MUSB_AM35X
> > -- 
> > 1.9.1
> > 
> > 
> > -- 
> > kernel-team mailing list
> > kernel-team@lists.ubuntu.com
> > https://lists.ubuntu.com/mailman/listinfo/kernel-team
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/