Date: Thu, 2 Apr 2015 20:06:26 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: cmetcalf@ezchip.com
Cc: Frederic Weisbecker <fweisbec@gmail.com>, Don Zickus <dzickus@redhat.com>,
        Ingo Molnar <mingo@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        Andrew Jones <drjones@redhat.com>,
        chai wen <chaiw.fnst@cn.fujitsu.com>,
        Ulrich Obergfell <uobergfe@redhat.com>,
        Fabian Frederick <fabf@skynet.be>, Aaron Tomlin <atomlin@redhat.com>,
        Ben Zhang <benzh@chromium.org>, Christoph Lameter <cl@linux.com>,
        Gilad Ben-Yossef <gilad@benyossef.com>,
        Steven Rostedt <rostedt@goodmis.org>, linux-kernel@vger.kernel.org,
        Jonathan Corbet <corbet@lwn.net>, linux-doc@vger.kernel.org
Subject: Re: [PATCH v3] watchdog: add watchdog_cpumask sysctl to assist nohz
Message-ID: <20150402180626.GG23123@twins.programming.kicks-ass.net>
References: <1427741465-15747-1-git-send-email-cmetcalf@ezchip.com>
 <20150331072502.GA16754@gmail.com>
 <551AE7D4.3020608@ezchip.com>
 <20150402133502.GA175361@redhat.com>
 <551D48F9.6090101@ezchip.com>
 <20150402141527.GD175361@redhat.com>
 <20150402153827.GC10357@lerouge>
 <551D6373.2030000@ezchip.com>
 <20150402164845.GD10357@lerouge>
 <1427996368-2199-1-git-send-email-cmetcalf@ezchip.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427996368-2199-1-git-send-email-cmetcalf@ezchip.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 666
Lines: 16

On Thu, Apr 02, 2015 at 01:39:28PM -0400, cmetcalf@ezchip.com wrote:
> @@ -431,6 +434,10 @@ static void watchdog_enable(unsigned int cpu)
>  	hrtimer_init(hrtimer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);
>  	hrtimer->function = watchdog_timer_fn;
>  
> +	/* Exit if the cpu is not allowed for watchdog. */
> +	if (!cpumask_test_cpu(cpu, watchdog_mask))
> +		do_exit(0);
> +

Ick, that doesn't look right for smpboot threads.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/