Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753257AbbDBSLh (ORCPT ); Thu, 2 Apr 2015 14:11:37 -0400 Received: from mail-la0-f50.google.com ([209.85.215.50]:34463 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752507AbbDBSLd (ORCPT ); Thu, 2 Apr 2015 14:11:33 -0400 MIME-Version: 1.0 In-Reply-To: References: <1425076217-10415-1-git-send-email-bjorn.andersson@sonymobile.com> Date: Thu, 2 Apr 2015 11:11:31 -0700 Message-ID: Subject: Re: [PATCH v6 1/2] DT: hwspinlock: Add binding documentation for Qualcomm hwmutex From: Tim Bird To: Ohad Ben-Cohen Cc: Bjorn Andersson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Suman Anna , "linux-arm-msm@vger.kernel.org" , Jeffrey Hugo , Andy Gross , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Greg Kroah-Hartman , Andrew Morton , Kevin Hilman , Arnd Bergmann Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3544 Lines: 107 On Wed, Apr 1, 2015 at 9:40 PM, Ohad Ben-Cohen wrote: > On Thu, Apr 2, 2015 at 12:32 AM, Tim Bird wrote: >> I didn't see an Ack from Mark or Rob. But I did see a question from >> Mark and response from Bjorn. >> >> Ohad - did you take this or are you still waiting for something? >> >> Who should I pester about this? :-) > > Sorry, I can't take this without a DT ack. Hmmm. The policy seems to be: "For driver (not subsystem) bindings: If you are comfortable with the binding, and it hasn't received an Acked-by from the devicetree maintainers after a few weeks, go ahead and take it." The syscon property is only relative to the qcom hwspinlock driver, (unless I'm missing something) and both Qualcomm and Sony devs are OK with it. So while an ACK from the DT side would be nice, I don't think it's required. This is exactly the type of delay that is really holding up a lot of out-of-tree code. But, in case that doesn't convince you... Mark or Rob (or someone, anyone, over on the DT side)... Can you please ACK or NAK the following binding? This particular driver is at the bottom of a very large dependency tree for out-of-tree code for Qualcomm. Thanks, -- Tim --- Add binding documentation for the Qualcomm Hardware Mutex. Signed-off-by: Bjorn Andersson --- I think the conclusion on the dt binding discussion for hwspinlocks was that we're down to having the #hwlock-cells intact. So this version includes that, but none of the other previously discussed properties. Changes since v5: - Extracted the dt binding documentation into a separate patch - Moved the driver to consume a syscon - Dropped previously suggested generic hwlock dt bindings .../devicetree/bindings/hwlock/qcom-hwspinlock.txt | 39 ++++++++++++++++++++++ 1 file changed, 39 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt diff --git a/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt new file mode 100644 index 0000000..28ade7d --- /dev/null +++ b/Documentation/devicetree/bindings/hwlock/qcom-hwspinlock.txt @@ -0,0 +1,39 @@ +Qualcomm Hardware Mutex Block: + +The hardware block provides mutexes utilized between different processors on +the SoC as part of the communication protocol used by these processors. + +- compatible: + Usage: required + Value type: + Definition: must be one of: + "qcom,sfpb-mutex", + "qcom,tcsr-mutex" + +- syscon: + Usage: required + Value type: + Definition: one cell containing: + syscon phandle + offset of the hwmutex block within the syscon + stride of the hwmutex registers + +- #hwlock-cells: + Usage: required + Value type: + Definition: must be 1, the specified cell represent the lock id + (hwlock standard property, see hwlock.txt) + +Example: + + tcsr: syscon@1a400000 { + compatible = "qcom,tcsr-msm8974", "syscon"; + reg = <0xfd484000 0x2000>; + }; + + hwlock@fd484000 { + compatible = "qcom,tcsr-mutex"; + syscon = <&tcsr 0 0x80>; + + #hwlock-cells = <1>; + }; -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/