Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbbDBS3T (ORCPT ); Thu, 2 Apr 2015 14:29:19 -0400 Received: from cavan.codon.org.uk ([93.93.128.6]:60691 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751054AbbDBS3Q (ORCPT ); Thu, 2 Apr 2015 14:29:16 -0400 Message-ID: <1427999332.7230.12.camel@srcf.ucam.org> From: Matthew Garrett To: Ross Lagerwall Cc: linux-efi@vger.kernel.org, Jeremy Kerr , Matt Fleming , linux-kernel@vger.kernel.org Date: Thu, 02 Apr 2015 11:28:52 -0700 In-Reply-To: <1427960340-5339-1-git-send-email-ross.lagerwall@citrix.com> References: <1427960340-5339-1-git-send-email-ross.lagerwall@citrix.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 (3.12.11-1.fc21) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SA-Do-Not-Run: Yes X-SA-Exim-Connect-IP: 50.250.250.41 X-SA-Exim-Mail-From: mjg59@srcf.ucam.org X-Spam-ASN: Subject: Re: [PATCH RESEND] efivarfs: Ensure VariableName is NUL-terminated X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:54:46 +0000) X-SA-Exim-Scanned: Yes (on cavan.codon.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1004 Lines: 25 On Thu, 2015-04-02 at 08:39 +0100, Ross Lagerwall wrote: > Some buggy firmware implementations update VariableNameSize on success > such that it does not include the final NUL character which results in > garbage in the efivarfs name entries. Use kzalloc on the efivar_entry > (as is done in efivars.c) to ensure that the name is always > NUL-terminated. > > The buggy firmware is: > BIOS Information > Vendor: Intel Corp. > Version: S1200RP.86B.02.02.0005.102320140911 > Release Date: 10/23/2014 > BIOS Revision: 4.6 > System Information > Manufacturer: Intel Corporation > Product Name: S1200RP_SE > > Signed-off-by: Ross Lagerwall ACKed-by: Matthew Garrett -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/