Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752984AbbDBWPA (ORCPT ); Thu, 2 Apr 2015 18:15:00 -0400 Received: from mail-qg0-f48.google.com ([209.85.192.48]:33630 "EHLO mail-qg0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbbDBWN6 (ORCPT ); Thu, 2 Apr 2015 18:13:58 -0400 MIME-Version: 1.0 In-Reply-To: References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <20150402.163715.643586069492103151.davem@davemloft.net> From: Bjorn Helgaas Date: Thu, 2 Apr 2015 17:13:37 -0500 Message-ID: Subject: Re: [PATCH 0/3] PCI/sparc: Fix booting with T5-8 To: Yinghai Lu Cc: David Miller , David Ahern , "linux-pci@vger.kernel.org" , "sparclinux@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1486 Lines: 38 On Thu, Apr 2, 2015 at 5:07 PM, Yinghai Lu wrote: > On Thu, Apr 2, 2015 at 1:37 PM, David Miller wrote: >> From: Yinghai Lu >> Date: Tue, 31 Mar 2015 19:57:46 -0700 >> >>> Fix regression by commit d63e2e1f3df9 ("sparc/PCI: Clip bridge windows to >>> fit in upstream windows"). >>> >>> That cause bridge bar get clipped wrongly. >>> >>> The sparc64 dma_addr_t is 32-bit, we can not use it to check if we can >>> use 64bit bar, introduce pci_bus_addr_t. >>> >>> sparc ofpci does not parse 64bit mem for root bus, add code to >>> make sure that we get correct resource for root. >>> >>> Also there are device 64-bit res does not have pref bit flag, but bridges >>> do have pref bit set, that cause extra "no compatible window". >>> Set pref bit for them according to the errata. >> >> Just to be clear, who is going to merge this? :-) >> > > Should be you or Bjorn, but one should get ack from another. I'm just getting back from vacation and would like to have a chance to look over this. One first reaction is that if we add a pci_bus_addr_t, Documentation/DMA-API-HOWTO.txt needs to be updated. It currently says a dma_addr_t "can hold any valid DMA or bus address." Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/