Message-ID: <1428018637.22867.306.camel@freescale.com>
Subject: Re: [PATCH] powerpc/83xx: add support for mpc8306
From: Scott Wood <scottwood@freescale.com>
To: Filip =?UTF-8?Q?Brozovi=C4=87?= <fbrozovic@gmail.com>
CC: <galak@kernel.crashing.org>, <benh@kernel.crashing.org>,
        <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Date: Thu, 2 Apr 2015 18:50:37 -0500
In-Reply-To: <551AFC7E.8090108@gmail.com>
References: <1427561968-32049-1-git-send-email-fbrozovic@gmail.com>
	 <1427824493.22867.226.camel@freescale.com> <551AFC7E.8090108@gmail.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Apr 2015 23:50:43.7545 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1474
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 978
Lines: 24

On Tue, 2015-03-31 at 21:58 +0200, Filip Brozović wrote:
> On 3/31/2015 7:54 PM, Scott Wood wrote:
> > This breaks multiplatform support.  You need to determine this at
> > runtime.
> 
> Understood, but I'm unsure of how to do this exactly. Would it be 
> appropriate to define another array, snum_init_14, with the SNUM values 
> for the MPC8306 QE, change the minimum number of SNUMs in 
> qe_get_num_of_snums() to 14 and set the correct values this way? In that 
> case, compatibility with other platforms would be kept intact, and the 
> QE device tree node for MPC8306 (and MPC8309) boards would just have to 
> have the fsl,qe-num-snums property set to 14 in order for the driver to 
> set the correct values.

Yes.

-Scott


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/