Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752080AbbDCGs3 (ORCPT ); Fri, 3 Apr 2015 02:48:29 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:36292 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751335AbbDCGs0 (ORCPT ); Fri, 3 Apr 2015 02:48:26 -0400 Date: Fri, 3 Apr 2015 08:48:22 +0200 From: Ingo Molnar To: Wang Nan Cc: jolsa@redhat.com, namhyung@kernel.org, jolsa@kernel.org, acme@redhat.com, linux-kernel@vger.kernel.org, pi3orama@163.com Subject: Re: [PATCH v2] perf: report/annotate: fix segfault problem. Message-ID: <20150403064822.GB29383@gmail.com> References: <1428040585-52586-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428040585-52586-1-git-send-email-wangnan0@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1940 Lines: 52 * Wang Nan wrote: > perf report and perf annotate are easy to trigger segfault if trace data > contain kernel module information like this: > > # perf report -D -i ./perf.data > ... > 0 0 0x188 [0x50]: PERF_RECORD_MMAP -1/0: [0xffffffbff1018000(0xf068000) @ 0]: x [test_module] > ... > > # perf report -i ./perf.data --objdump=/path/to/objdump --kallsyms=/path/to/kallsyms > > perf: Segmentation fault > -------- backtrace -------- > /path/to/perf[0x503478] > /lib64/libc.so.6(+0x3545f)[0x7fb201f3745f] > /path/to/perf[0x499b56] > /path/to/perf(dso__load_kallsyms+0x13c)[0x49b56c] > /path/to/perf(dso__load+0x72e)[0x49c21e] > /path/to/perf(map__load+0x6e)[0x4ae9ee] > /path/to/perf(thread__find_addr_map+0x24c)[0x47deec] > /path/to/perf(perf_event__preprocess_sample+0x88)[0x47e238] > /path/to/perf[0x43ad02] > /path/to/perf[0x4b55bc] > /path/to/perf(ordered_events__flush+0xca)[0x4b57ea] > /path/to/perf[0x4b1a01] > /path/to/perf(perf_session__process_events+0x3be)[0x4b428e] > /path/to/perf(cmd_report+0xf11)[0x43bfc1] > /path/to/perf[0x474702] > /path/to/perf(main+0x5f5)[0x42de95] > /lib64/libc.so.6(__libc_start_main+0xf4)[0x7fb201f23bd4] > /path/to/perf[0x42dfc4] > > This is because __kmod_path__parse regard '[' leading name as kernel > instead of kernel module. The DSO will then be passed to > dso__load_kernel_sym() then dso__load_kcore() because of --kallsyms > argument. The segfault is triggered because the kmap structure is not > initialized. Could we also make the place that generated the segfault more robust, to protect against future mishaps of this type? I suppose the non-initialized value was NULL? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/