Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753353AbbDCIoP (ORCPT ); Fri, 3 Apr 2015 04:44:15 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:51969 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752115AbbDCIoM (ORCPT ); Fri, 3 Apr 2015 04:44:12 -0400 Message-ID: <551E52BC.3040702@atmel.com> Date: Fri, 3 Apr 2015 10:43:40 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: , Arnd Bergmann , Olof Johansson , Kevin Hilman , "ARM Maintainers" CC: , , Boris BREZILLON , Alexandre Belloni , Johan Hovold , Subject: Re: [PATCH] ARM: at91/dt: sama5d3 xplained: add phy address for macb1 References: <1427792170-13162-1-git-send-email-nicolas.ferre@atmel.com> In-Reply-To: <1427792170-13162-1-git-send-email-nicolas.ferre@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1636 Lines: 53 Le 31/03/2015 10:56, Nicolas Ferre a ?crit : > After 57a38effa598 (net: phy: micrel: disable broadcast for KSZ8081/KSZ8091) > the macb1 interface refuses to work properly because it tries > to cling to address 0 which isn't able to communicate in broadcast with > the mac anymore. The micrel phy on the board is actually configured > to show up at address 1. > Adding the phy node and its real address fixes the issue. > > Signed-off-by: Nicolas Ferre > Cc: Johan Hovold > Cc: #3.19 > --- Arnd, Olof, Kevin, It seems late but, is it possible to queue this patch as a 4.0 fixes? Without it, the 10/100 Ethernet on sama5d3 doesn't work if it's not used by u-boot previously. Bye, > arch/arm/boot/dts/at91-sama5d3_xplained.dts | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > index fec1fca2ad66..6c4bc53cbf4e 100644 > --- a/arch/arm/boot/dts/at91-sama5d3_xplained.dts > +++ b/arch/arm/boot/dts/at91-sama5d3_xplained.dts > @@ -167,7 +167,13 @@ > > macb1: ethernet@f802c000 { > phy-mode = "rmii"; > + #address-cells = <1>; > + #size-cells = <0>; > status = "okay"; > + > + ethernet-phy@1 { > + reg = <0x1>; > + }; > }; > > dbgu: serial@ffffee00 { > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/