From: Madalin-Cristian Bucur <madalin.bucur@freescale.com>
To: Paul Bolle <pebolle@tiscali.nl>
CC: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Topic: [PATCH RFC 02/10] dpaa_eth: add support for DPAA Ethernet
Thread-Index: AQHQbJe2LWr01iCNrECqTTVPTBGDP505irAAgAF0CBA=
Date: Fri, 3 Apr 2015 08:58:12 +0000
Message-ID: <BL2PR03MB545A59DD0E2700AF630C468E6F10@BL2PR03MB545.namprd03.prod.outlook.com>
References: <1427905196-27778-1-git-send-email-madalin.bucur@freescale.com>
 <1427971444.10518.40.camel@x220>
In-Reply-To: <1427971444.10518.40.camel@x220>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2015 08:58:12.5146
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR03MB545
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id t338wSZG015294
Content-Length: 3152
Lines: 93

> -----Original Message-----
> From: Paul Bolle [mailto:pebolle@tiscali.nl]
> 
> Just a few nits.
> 
> This series is posted as an RFC, so this might not be what you're
> expecting right now. But as these messages got tangled up in my mail
> filter anyhow, I thought I might as well bother you with these nits now.
> 
> On Wed, 2015-04-01 at 19:19 +0300, Madalin Bucur wrote:
> > --- /dev/null
> > +++ b/drivers/net/ethernet/freescale/dpaa/Kconfig
> > @@ -0,0 +1,49 @@
> > +menuconfig FSL_DPAA_ETH
> > +	tristate "DPAA Ethernet"
> > +	depends on FSL_SOC && FSL_BMAN && FSL_QMAN && FSL_FMAN
> > +	select PHYLIB
> > +	select FSL_FMAN_MAC
> > +	---help---
> > +	  Data Path Acceleration Architecture Ethernet driver,
> > +	  supporting the Freescale QorIQ chips.
> > +	  Depends on Freescale Buffer Manager and Queue Manager
> > +	  driver and Frame Manager Driver.
> > +
> > +if FSL_DPAA_ETH
> > +
> > +config FSL_DPAA_CS_THRESHOLD_1G
> > +	hex "Egress congestion threshold on 1G ports"
> > +	depends on FSL_DPAA_ETH
> 
> This entry is inside the "if FSL_DPAA_ETH" block. So this line should be
> superfluous.

Will address this and the other occurrences.

> > +	range 0x1000 0x10000000
> > +	default "0x06000000"
> > +	---help---
> > +	  The size in bytes of the egress Congestion State notification
> threshold on 1G ports.
> > +	  The 1G dTSECs can quite easily be flooded by cores doing Tx in a
> tight loop
> > +	  (e.g. by sending UDP datagrams at "while(1) speed"),
> > +	  and the larger the frame size, the more acute the problem.
> > +	  So we have to find a balance between these factors:
> > +	       - avoiding the device staying congested for a prolonged time
> (risking
> > +                 the netdev watchdog to fire - see also the tx_timeout module
> param);
> > +               - affecting performance of protocols such as TCP, which otherwise
> > +	         behave well under the congestion notification mechanism;
> > +	       - preventing the Tx cores from tightly-looping (as if the
> congestion
> > +	         threshold was too low to be effective);
> > +	       - running out of memory if the CS threshold is set too high.
> > +
> > +config FSL_DPAA_CS_THRESHOLD_10G
> > +	hex "Egress congestion threshold on 10G ports"
> > +	depends on FSL_DPAA_ETH
> 
> Ditto.
> 
> > +	range 0x1000 0x20000000
> > +	default "0x10000000"
> > +	---help ---
> > +	  The size in bytes of the egress Congestion State notification
> threshold on 10G ports.
> > +
> > +config FSL_DPAA_INGRESS_CS_THRESHOLD
> > +	hex "Ingress congestion threshold on FMan ports"
> > +	depends on FSL_DPAA_ETH
> 
> Ditto.
> 
> > +	default "0x10000000"
> > +	---help---
> > +	  The size in bytes of the ingress tail-drop threshold on FMan ports.
> > +	  Traffic piling up above this value will be rejected by QMan and
> discarded by FMan.
> > +
> > +endif # FSL_DPAA_ETH
> 
> A similar comment can be made for the entries added in 03/10, 05/10, and
> 09/10.
> 
> Thanks,
> 
> 
> Paul Bolle

Thank you,
Madalin
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?