Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753318AbbDCOIf (ORCPT ); Fri, 3 Apr 2015 10:08:35 -0400 Received: from arroyo.ext.ti.com ([192.94.94.40]:42317 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753089AbbDCOH7 (ORCPT ); Fri, 3 Apr 2015 10:07:59 -0400 Message-ID: <551E9E90.3080406@ti.com> Date: Fri, 3 Apr 2015 19:37:12 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.0 MIME-Version: 1.0 To: Arun Ramamurthy , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Arnd Bergmann , CC: , , , Dmitry Torokhov , Anatol Pomazau , Jonathan Richardson , Scott Branden , Ray Jui Subject: Re: [PATCH v2 2/3] Phy: DT binding documentation for Broadcom Cygnus USB PHY driver References: <1427921457-18235-1-git-send-email-arun.ramamurthy@broadcom.com> <1427921457-18235-3-git-send-email-arun.ramamurthy@broadcom.com> In-Reply-To: <1427921457-18235-3-git-send-email-arun.ramamurthy@broadcom.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2758 Lines: 87 Hi, On Thursday 02 April 2015 02:20 AM, Arun Ramamurthy wrote: > Broadcom's Cygnus chip has a USB 2.0 host controller connected to > three separate phys. One of the phs (port 2) is also connectd to > a usb 2.0 device controller > > Signed-off-by: Arun Ramamurthy > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > --- > .../bindings/phy/brcm,cygnus-usb-phy.txt | 69 ++++++++++++++++++++++ > 1 file changed, 69 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/brcm,cygnus-usb-phy.txt > > diff --git a/Documentation/devicetree/bindings/phy/brcm,cygnus-usb-phy.txt b/Documentation/devicetree/bindings/phy/brcm,cygnus-usb-phy.txt > new file mode 100644 > index 0000000..d1a9a65 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/brcm,cygnus-usb-phy.txt > @@ -0,0 +1,69 @@ > +BROADCOM CYGNUS USB PHY > + > +Required Properties: > + - compatible: brcm,cygnus-usb-phy > + - reg : usbphy_regs - Base address of phy registers > + usb2h_idm_regs - Base address of host idm registers > + usb2d_idm_regs - Base address of device idm registers > + - phy-cells - must be 1 for each port declared. This is because the node > + that uses the phy must provide one integers, 0 for device > + and 1 for host Try to define standard constants in include/dt-bindings/phy/phy.h > + > +NOTE: port 0 and port 1 are host only and port 2 can be configured for host or > +device. > + > +Example of phy : > + usbphy0: usbphy@0x0301c000 { > + compatible = "brcm,cygnus-usb-phy"; > + reg = <0x0301c000 0x2000>, > + <0x18115000 0x1000>, > + <0x18111000 0x1000>; > + status = "okay"; > + > + #address-cells = <1>; > + #size-cells = <0>; > + usbphy0_0: usbphy0@0 { > + #phy-cells = <1>; > + reg = <0>; > + status = "okay"; > + phy-supply = <&vbus_p0>; > + }; > + > + usbphy0_1: usbphy0@1 { > + #phy-cells = <1>; > + reg = <1>; > + status = "okay"; > + }; > + > + usbphy0_2: usbphy0@2 { > + #phy-cells = <1>; > + reg = <2>; > + status = "okay"; > + phy-supply = <&vbus_p2>; > + }; > + }; > + > +Example of node using the phy: > + > + /* This nodes declares all three ports as host */ > + > + ehci0: usb@0x18048000 { > + compatible = "generic-ehci"; > + reg = <0x18048000 0x100>; > + interrupts = ; > + phys = <&usbphy0_0 1 &usbphy0_1 1 &usbphy0_2 1>; And use the constants here instead of numbers. Regards Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/