Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752743AbbDCOMh (ORCPT ); Fri, 3 Apr 2015 10:12:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21373 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752223AbbDCOMg (ORCPT ); Fri, 3 Apr 2015 10:12:36 -0400 Date: Fri, 3 Apr 2015 16:14:26 +0200 From: Quentin Casasnovas To: Quentin Casasnovas Cc: Borislav Petkov , X86 ML , LKML , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Oleg Nesterov , Andy Lutomirski Subject: Re: [PATCH] x86/xsave: Robustify and merge macros Message-ID: <20150403141426.GE14902@chrystal.uk.oracle.com> References: <1427980282-25929-1-git-send-email-bp@alien8.de> <20150402155210.GB6703@chrystal.uk.oracle.com> <20150402161259.GE3483@pd.tnic> <20150403140630.GD14902@chrystal.uk.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150403140630.GD14902@chrystal.uk.oracle.com> User-Agent: Mutt/1.5.22 (2013-10-16) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1567 Lines: 41 On Fri, Apr 03, 2015 at 04:06:30PM +0200, Quentin Casasnovas wrote: > On Thu, Apr 02, 2015 at 06:12:59PM +0200, Borislav Petkov wrote: > > On Thu, Apr 02, 2015 at 05:52:10PM +0200, Quentin Casasnovas wrote: > > > I've tried compiling this on top of v4.0-rc5 and I get a compile error > > > because alt_end_marker isn't defined. Which other patches should I take to > > > test this? > > > > It needs tip/master. > > > > So I've had a look at tip/master and I don't _think_ commit > > 4332195 ("x86/alternatives: Add instruction padding") > > is correct. > > [...] > > we can use something like this even more horrible line: Derp! Already spotted a couple of errors below.. > > .skip -(((145f - 144f) - ((-(((144f - 143f) - (141b - 140b)) > 0) * (144f - 143f)) + > (-(((144f - 143f) - (141b - 140b)) <= 0) * (141b - 143b)))) > 0) * ^ 140b > ((145f - 144f) - ((-(((144f - 143f) - (141b - 140b)) > 0) * (144f - 143f)) + > (-(((144f - 143f) - (141b - 140b)) <= 0) * (141b - 143b)))) ^ 140b > > This is obviously completely un-tested and not even compiled! :) > Told you! Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/