Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752626AbbDCPjN (ORCPT ); Fri, 3 Apr 2015 11:39:13 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:33865 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751497AbbDCPjF (ORCPT ); Fri, 3 Apr 2015 11:39:05 -0400 Date: Fri, 3 Apr 2015 17:40:55 +0200 From: Quentin Casasnovas To: Borislav Petkov Cc: Quentin Casasnovas , X86 ML , LKML , "H. Peter Anvin" , Ingo Molnar , Thomas Gleixner , Oleg Nesterov , Andy Lutomirski Subject: Re: [PATCH] x86/xsave: Robustify and merge macros Message-ID: <20150403154055.GF14902@chrystal.uk.oracle.com> References: <1427980282-25929-1-git-send-email-bp@alien8.de> <20150402155210.GB6703@chrystal.uk.oracle.com> <20150402161259.GE3483@pd.tnic> <20150403140630.GD14902@chrystal.uk.oracle.com> <20150403141426.GE14902@chrystal.uk.oracle.com> <20150403152324.GG3418@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150403152324.GG3418@pd.tnic> User-Agent: Mutt/1.5.22 (2013-10-16) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1178 Lines: 32 On Fri, Apr 03, 2015 at 05:23:24PM +0200, Borislav Petkov wrote: > On Fri, Apr 03, 2015 at 04:14:26PM +0200, Quentin Casasnovas wrote: > > > This is obviously completely un-tested and not even compiled! :) > > > > > > > Told you! > > :-) > > So all clear or we need to do more discussing? > > Basically, the .skip is supposed to add 0x90 only when the evaluated > expression is true (yeah, gas works with signed 32-bit values so it > evaluates either to 0 or -1, thus the games with "-" in front). > Oh yeah that was clear from the beggings, there was just a typo in my initial suggestion to fix what I _think_ the problem is (which I've fixed inlined so you might have missed it). So yeah I still think we're not properly padding, if you take my earlier example where repl2 = 5 bytes, repl1 = 4 bytes and orin_insn = 3. I'll let you re-read my original mail and come back to me to tell me what'd I really miss! :) Quentin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/