Message-ID: <1428080470.13180.19.camel@perches.com>
Subject: Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed
 value
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com>, gregkh@linuxfoundation.org,
        devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Date: Fri, 03 Apr 2015 10:01:10 -0700
In-Reply-To: <20150403165113.GU10964@mwanda>
References: <20150403164211.GA6422@amitoj-Inspiron-3542>
	 <20150403165113.GU10964@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 908
Lines: 27

On Fri, 2015-04-03 at 19:51 +0300, Dan Carpenter wrote:
> On Fri, Apr 03, 2015 at 10:12:11PM +0530, Amitoj Kaur Chawla wrote:
> > Removes variable comparison with 0 by using !. 
> 
> Sometimes testing for zero makes sense.
> When you write code, you are
> telling a story.  If you are talking about zero as a number then it
> can make sense.  If it's zero as a boolean then it doesn't make sense.

Very true.

> Also strcmp() and similar should always be done as == 0, < 0 or != 0
> because that is the idiom:

Less true.

When testing for equality, !strcmp is very common.

There are ~2500 uses of !strcmp in the kernel tree vs
~1500 uses of strcmp() == or !=


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/