Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752324AbbDCUCg (ORCPT ); Fri, 3 Apr 2015 16:02:36 -0400 Received: from mailsec118.isp.belgacom.be ([195.238.20.114]:6725 "EHLO mailsec118.isp.belgacom.be" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751495AbbDCUCe convert rfc822-to-8bit (ORCPT ); Fri, 3 Apr 2015 16:02:34 -0400 X-Cloudmark-SP-Filtered: true X-Cloudmark-SP-Result: v=1.1 cv=yz6z4UlqfYe1Iv9USMliYggvHmbgQ4ACOrhY3D/q6Wc= c=1 sm=2 a=IkcTkHD0fZMA:10 a=J1Y8HTJGAAAA:8 a=LT8qdoyFAAAA:8 a=1OuBD4IMnNDITyZwbFIA:9 a=QEXdDO2ut3YA:10 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A2CyDABR8R5V/9MU7sNcgwuBLoMVrycBAQEBAQaZJQKBKkwBAQEBAQF+QQKDWwEBAQMBI1YFCwUEAhQBAwICGA4CAlcGARIRiBYMmCOcf4ZTkTMBAQEBBgEBAQEegSGEboUahEYzB4JogUUFpjSJAyKCAxyBUjwxgkMBAQE Date: Fri, 3 Apr 2015 22:02:32 +0200 (CEST) From: Fabian Frederick Reply-To: Fabian Frederick To: hideaki.yoshifuji@miraclelinux.com, David Miller Cc: pablo@netfilter.org, coreteam@netfilter.org, herbert@gondor.apana.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, yoshfuji@linux-ipv6.org, netfilter-devel@vger.kernel.org, steffen.klassert@secunet.com, jmorris@namei.org, kuznet@ms2.inr.ac.ru, kadlec@blackhole.kfki.hu, kaber@trash.net Message-ID: <911278303.335976.1428091352576.open-xchange@webmail.nmp.proximus.be> In-Reply-To: <20150331.111752.1605776715849912657.davem@davemloft.net> References: <1427749998-28464-1-git-send-email-fabf@skynet.be> <1427749998-28464-4-git-send-email-fabf@skynet.be> <551A1983.40408@miraclelinux.com> <20150331.111752.1605776715849912657.davem@davemloft.net> Subject: Re: [PATCH 4/9 net-next] ipv6: replace if/BUG by BUG_ON MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.2.2-Rev27 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1992 Lines: 62 > On 31 March 2015 at 17:17 David Miller wrote: > > > From: YOSHIFUJI Hideaki > Date: Tue, 31 Mar 2015 12:50:27 +0900 > > > Hi, > > > > Fabian Frederick wrote: > >> Signed-off-by: Fabian Frederick > >> --- > >>  net/ipv6/addrconf.c                     | 3 +-- > >>  net/ipv6/esp6.c                         | 3 +-- > >>  net/ipv6/netfilter/nf_conntrack_reasm.c | 3 +-- > >>  3 files changed, 3 insertions(+), 6 deletions(-) > >> > >> diff --git a/net/ipv6/addrconf.c b/net/ipv6/addrconf.c > >> index 2660263..e205918 100644 > >> --- a/net/ipv6/addrconf.c > >> +++ b/net/ipv6/addrconf.c > >> @@ -4805,8 +4805,7 @@ static int inet6_set_link_af(struct net_device *dev, > >> const struct nlattr *nla) > >>    if (!idev) > >>            return -EAFNOSUPPORT; > >>  > >> -  if (nla_parse_nested(tb, IFLA_INET6_MAX, nla, NULL) < 0) > >> -          BUG(); > >> +  BUG_ON(nla_parse_nested(tb, IFLA_INET6_MAX, nla, NULL) < 0); > >>  > > > > NACK, I do not prefer using BUG_ON() with side effects. > > Agreed, I do not like these changes at all and will not be > applying them. I guess patches like these should be reverted then ? e3f0b86b996d "ipv6: Use BUG_ON" 8242fc33925c "net: ipv6: Use BUG_ON" Some existing BUG_ON() as well ? ; eg second one in net/decnet/dn_rules.c: void __init dn_fib_rules_init(void) {         dn_fib_rules_ops =                 fib_rules_register(&dn_fib_rules_ops_template, &init_net);         BUG_ON(IS_ERR(dn_fib_rules_ops));         BUG_ON(fib_default_rule_add(dn_fib_rules_ops, 0x7fff,                                     RT_TABLE_MAIN, 0)); } Regards, Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/