Message-ID: <1428096660.7898.27.camel@x220>
Subject: Re: [PATCH v2] powerpc/83xx: add support for mpc8306
From: Paul Bolle <pebolle@tiscali.nl>
To: Filip =?UTF-8?Q?Brozovi=C4=87?= <fbrozovic@gmail.com>
Cc: scottwood@freescale.com, galak@kernel.crashing.org,
        benh@kernel.crashing.org, linuxppc-dev@lists.ozlabs.org,
        linux-kernel@vger.kernel.org
Date: Fri, 03 Apr 2015 23:31:00 +0200
In-Reply-To: <551E8B65.5010400@gmail.com>
References: <1428057856-26421-1-git-send-email-fbrozovic@gmail.com>
	 <1428062487.7898.12.camel@x220> <551E8B65.5010400@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1067
Lines: 25

On Fri, 2015-04-03 at 14:45 +0200, Filip Brozović wrote:
> The idea was that boards in the Kconfig file would select these symbols 
> in order to enable support for the 8306. I mainly wanted to get this 
> patch into mainline in order to make kernel maintenance for a couple of 
> custom in-house developed boards easier.

The trouble with this patch is that, without some follow up patch, it
adds Kconfig symbols and preprocessor checks that are pointless for
mainline. I think we should not do that. (I'm also not sure how having
those bits in mainline substantially benefits out of tree development.)

But if you would put this in a series that also adds the code using
these bits, than I'd have no reason to object (and neither would, I
guess, the bots checking the tree for issues like that).

Thanks,


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/