Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752862AbbDCVjj (ORCPT ); Fri, 3 Apr 2015 17:39:39 -0400 Received: from nblzone-211-213.nblnetworks.fi ([83.145.211.213]:51177 "EHLO hillosipuli.retiisi.org.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752315AbbDCVjh (ORCPT ); Fri, 3 Apr 2015 17:39:37 -0400 Date: Sat, 4 Apr 2015 00:39:33 +0300 From: Sakari Ailus To: Pavel Machek Cc: Andrew Morton , pali.rohar@gmail.com, sre@debian.org, sre@ring0.de, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, galak@codeaurora.org, bcousson@baylibre.com, m.chehab@samsung.com, devicetree@vger.kernel.org Subject: Re: [PATCHv6] media: i2c/adp1653: Documentation for devicetree support for adp1653 Message-ID: <20150403213933.GP20756@valkosipuli.retiisi.org.uk> References: <20150402143846.GA11687@amd> <20150402203417.GA6336@amd> <20150403083353.GA21070@amd> <20150403113216.GK20756@valkosipuli.retiisi.org.uk> <20150403202624.GA4308@amd> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150403202624.GA4308@amd> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 943 Lines: 23 On Fri, Apr 03, 2015 at 10:26:24PM +0200, Pavel Machek wrote: > > > + - power-gpios: Reference to the GPIO that controls the power for the chip. > > > > You're using power-gpios in documentation only. > > Which is ok, because generic code adds "-gpios" itself. Do you think you need this part: + if (!of_find_property(node, "gpios", NULL)) { + dev_err(&client->dev, "No gpio node\n"); + return -EINVAL; + } -- Sakari Ailus e-mail: sakari.ailus@iki.fi XMPP: sailus@retiisi.org.uk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/