Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752586AbbDCV6b (ORCPT ); Fri, 3 Apr 2015 17:58:31 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49018 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751923AbbDCV6a (ORCPT ); Fri, 3 Apr 2015 17:58:30 -0400 Date: Fri, 3 Apr 2015 14:58:28 -0700 From: Andrew Morton To: Stefan Strogin Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dmitry Safonov , Stefan Strogin , Michal Nazarewicz , Marek Szyprowski , Joonsoo Kim , "Aneesh Kumar K . V" , Pintu Kumar , Sasha Levin , Weijie Yang , Laurent Pinchart , Michal Hocko , Vyacheslav Tyrtov , Aleksei Mateosian Subject: Re: [PATCH] mm: cma: add functions to get region pages counters Message-Id: <20150403145828.90a597f5dc1c308d7c31a37d@linux-foundation.org> In-Reply-To: <1428064960-8279-1-git-send-email-stefan.strogin@gmail.com> References: <1428064960-8279-1-git-send-email-stefan.strogin@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5775 Lines: 192 On Fri, 03 Apr 2015 15:42:40 +0300 Stefan Strogin wrote: > From: Dmitry Safonov > > Here are two functions that provide interface to compute/get used size > and size of biggest free chunk in cma region. Add that information to debugfs. > > ... > > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -53,6 +53,36 @@ unsigned long cma_get_size(const struct cma *cma) > return cma->count << PAGE_SHIFT; > } > > +unsigned long cma_get_used(struct cma *cma) > +{ > + unsigned long ret = 0; > + > + mutex_lock(&cma->lock); > + /* pages counter is smaller than sizeof(int) */ > + ret = bitmap_weight(cma->bitmap, (int)cma->count); > + mutex_unlock(&cma->lock); > + > + return ret << cma->order_per_bit; > +} > + > +unsigned long cma_get_maxchunk(struct cma *cma) > +{ > + unsigned long maxchunk = 0; > + unsigned long start, end = 0; > + > + mutex_lock(&cma->lock); > + for (;;) { > + start = find_next_zero_bit(cma->bitmap, cma->count, end); > + if (start >= cma->count) > + break; > + end = find_next_bit(cma->bitmap, cma->count, start); > + maxchunk = max(end - start, maxchunk); > + } > + mutex_unlock(&cma->lock); > + > + return maxchunk << cma->order_per_bit; > +} This will cause unused code to be included in cma.o when CONFIG_CMA_DEBUGFS=n. Please review the below patch which moves it all into cma_debug.c > --- a/mm/cma_debug.c > +++ b/mm/cma_debug.c > @@ -33,6 +33,28 @@ static int cma_debugfs_get(void *data, u64 *val) > > DEFINE_SIMPLE_ATTRIBUTE(cma_debugfs_fops, cma_debugfs_get, NULL, "%llu\n"); > > +static int cma_used_get(void *data, u64 *val) > +{ > + struct cma *cma = data; > + > + *val = cma_get_used(cma); > + > + return 0; > +} We have cma_used_get() and cma_get_used(). Confusing! Can we think of better names for one or both of them? From: Andrew Morton Subject: mm-cma-add-functions-to-get-region-pages-counters-fix move debug code from cma.c into cma_debug.c so it doesn't get included in CONFIG_CMA_DEBUGFS=n builds Cc: Dmitry Safonov Cc: Michal Nazarewicz Cc: Stefan Strogin Cc: Marek Szyprowski Cc: Joonsoo Kim Cc: Pintu Kumar Cc: Weijie Yang Cc: Laurent Pinchart Cc: Vyacheslav Tyrtov Cc: Aleksei Mateosian Signed-off-by: Andrew Morton --- include/linux/cma.h | 2 -- mm/cma.c | 30 ------------------------------ mm/cma_debug.c | 31 +++++++++++++++++++++++++++++++ 3 files changed, 31 insertions(+), 32 deletions(-) diff -puN include/linux/cma.h~mm-cma-add-functions-to-get-region-pages-counters-fix include/linux/cma.h --- a/include/linux/cma.h~mm-cma-add-functions-to-get-region-pages-counters-fix +++ a/include/linux/cma.h @@ -18,8 +18,6 @@ struct cma; extern unsigned long totalcma_pages; extern phys_addr_t cma_get_base(const struct cma *cma); extern unsigned long cma_get_size(const struct cma *cma); -extern unsigned long cma_get_used(struct cma *cma); -extern unsigned long cma_get_maxchunk(struct cma *cma); extern int __init cma_declare_contiguous(phys_addr_t base, phys_addr_t size, phys_addr_t limit, diff -puN mm/cma.c~mm-cma-add-functions-to-get-region-pages-counters-fix mm/cma.c --- a/mm/cma.c~mm-cma-add-functions-to-get-region-pages-counters-fix +++ a/mm/cma.c @@ -53,36 +53,6 @@ unsigned long cma_get_size(const struct return cma->count << PAGE_SHIFT; } -unsigned long cma_get_used(struct cma *cma) -{ - unsigned long ret = 0; - - mutex_lock(&cma->lock); - /* pages counter is smaller than sizeof(int) */ - ret = bitmap_weight(cma->bitmap, (int)cma->count); - mutex_unlock(&cma->lock); - - return ret << cma->order_per_bit; -} - -unsigned long cma_get_maxchunk(struct cma *cma) -{ - unsigned long maxchunk = 0; - unsigned long start, end = 0; - - mutex_lock(&cma->lock); - for (;;) { - start = find_next_zero_bit(cma->bitmap, cma->count, end); - if (start >= cma->count) - break; - end = find_next_bit(cma->bitmap, cma->count, start); - maxchunk = max(end - start, maxchunk); - } - mutex_unlock(&cma->lock); - - return maxchunk << cma->order_per_bit; -} - static unsigned long cma_bitmap_aligned_mask(const struct cma *cma, int align_order) { diff -puN mm/cma_debug.c~mm-cma-add-functions-to-get-region-pages-counters-fix mm/cma_debug.c --- a/mm/cma_debug.c~mm-cma-add-functions-to-get-region-pages-counters-fix +++ a/mm/cma_debug.c @@ -22,6 +22,37 @@ struct cma_mem { static struct dentry *cma_debugfs_root; +static unsigned long cma_get_used(struct cma *cma) +{ + unsigned long ret = 0; + + mutex_lock(&cma->lock); + /* pages counter is smaller than sizeof(int) */ + ret = bitmap_weight(cma->bitmap, (int)cma->count); + mutex_unlock(&cma->lock); + + return ret << cma->order_per_bit; +} + +static unsigned long cma_get_maxchunk(struct cma *cma) +{ + unsigned long maxchunk = 0; + unsigned long start, end = 0; + + mutex_lock(&cma->lock); + for (;;) { + start = find_next_zero_bit(cma->bitmap, cma->count, end); + if (start >= cma->count) + break; + end = find_next_bit(cma->bitmap, cma->count, start); + maxchunk = max(end - start, maxchunk); + } + mutex_unlock(&cma->lock); + + return maxchunk << cma->order_per_bit; +} + + static int cma_debugfs_get(void *data, u64 *val) { unsigned long *p = data; _ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/