Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752555AbbDDHuP (ORCPT ); Sat, 4 Apr 2015 03:50:15 -0400 Received: from mail-wi0-f182.google.com ([209.85.212.182]:38494 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752008AbbDDHuM (ORCPT ); Sat, 4 Apr 2015 03:50:12 -0400 Message-ID: <551F90EC.20600@gmail.com> Date: Sat, 04 Apr 2015 08:21:16 +0100 From: "Michael Kerrisk (man-pages)" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Rientjes CC: mtk.manpages@gmail.com, Andrew Morton , "Kirill A. Shutemov" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-man@vger.kernel.org Subject: Re: [patch] madvise.2: specify MADV_REMOVE returns EINVAL for hugetlbfs References: In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1508 Lines: 48 On 04/02/2015 11:21 PM, David Rientjes wrote: > madvise(2) actually returns with error EINVAL for MADV_REMOVE when used > for hugetlb vmas, not EOPNOTSUPP, and this has been the case since > MADV_REMOVE was introduced in commit f6b3ec238d12 ("madvise(MADV_REMOVE): > remove pages from tmpfs shm backing store"). Thanks David. Applied. I'd already fixed the appropriate piece in the ERRORS list a while back, but missed that piece in the main text. Cheers, Michael > Specify the exact behavior. > > Signed-off-by: David Rientjes > --- > man2/madvise.2 | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/man2/madvise.2 b/man2/madvise.2 > index a3d93bb..00db39d 100644 > --- a/man2/madvise.2 > +++ b/man2/madvise.2 > @@ -184,7 +184,9 @@ any filesystem which supports the > .BR FALLOC_FL_PUNCH_HOLE > mode also supports > .BR MADV_REMOVE . > -Other filesystems fail with the error > +Hugetlbfs will fail with the error > +.BR EINVAL > +and other filesystems fail with the error > .BR EOPNOTSUPP . > .TP > .BR MADV_DONTFORK " (since Linux 2.6.16)" > -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Linux/UNIX System Programming Training: http://man7.org/training/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/