Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752528AbbDDJlB (ORCPT ); Sat, 4 Apr 2015 05:41:01 -0400 Received: from mail-wg0-f47.google.com ([74.125.82.47]:36725 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752250AbbDDJk7 (ORCPT ); Sat, 4 Apr 2015 05:40:59 -0400 Date: Sat, 4 Apr 2015 11:40:54 +0200 From: Ingo Molnar To: Toshi Kani Cc: Yinghai Lu , Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List , the arch/x86 maintainers , Jens Axboe Subject: Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type Message-ID: <20150404094054.GA21027@gmail.com> References: <1427872339-6688-1-git-send-email-hch@lst.de> <1427872339-6688-2-git-send-email-hch@lst.de> <1428077687.31093.120.camel@misato.fc.hp.com> <1428094444.31093.122.camel@misato.fc.hp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1428094444.31093.122.camel@misato.fc.hp.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 46 * Toshi Kani wrote: > On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: > > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: > > > : > > >> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) > > >> /* > > >> * Find the highest page frame number we have available > > >> */ > > >> -static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type) > > >> +static unsigned long __init e820_end_pfn(unsigned long limit_pfn) > > >> { > > >> int i; > > >> unsigned long last_pfn = 0; > > >> @@ -759,7 +769,11 @@ static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type) > > >> unsigned long start_pfn; > > >> unsigned long end_pfn; > > >> > > >> - if (ei->type != type) > > >> + /* > > >> + * Persistent memory is accounted as ram for purposes of > > >> + * establishing max_pfn and mem_map. > > >> + */ > > >> + if (ei->type != E820_RAM && ei->type != E820_PRAM) > > >> continue; > > > > > > Should we also delete this code, accounting E820_PRAM as ram, along with > > > the deletion of reserve_pmem() in this version? > > > > should revert those end_of_ram change as attached. > > I confirmed that the pmem driver works with the change, and last_pfn is > updated as expected. Could someone please send the fix with a changelog, etc? Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/