Message-ID: <1428162741.2775.41.camel@perches.com>
Subject: Re: [PATCH] Staging: rtl8188eu: Remove zero testing pointer typed
 value
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Date: Sat, 04 Apr 2015 08:52:21 -0700
In-Reply-To: <20150404135818.GW10964@mwanda>
References: <20150403164211.GA6422@amitoj-Inspiron-3542>
	 <20150403165113.GU10964@mwanda> <1428080470.13180.19.camel@perches.com>
	 <20150403210458.GV10964@mwanda> <20150404135818.GW10964@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 754
Lines: 20

On Sat, 2015-04-04 at 16:58 +0300, Dan Carpenter wrote:
> On Sat, Apr 04, 2015 at 12:04:59AM +0300, Dan Carpenter wrote:
> > 1)  It's more clear when read in English.  "if not strcmp then" or
> > "if strcmp NOT EQUAL zero".
> Oops.  I got that reversed.  I meant "if strcmp then".  Only serves to
> emphasize my point though.  :)

When I read it I understood what you meant, but
I thought the point was everybody makes mistakes.

!strcmp to test equality is still pretty idiomatic.
!memcmp too.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/