Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752657AbbDEDh0 (ORCPT ); Sat, 4 Apr 2015 23:37:26 -0400 Received: from hofr.at ([212.69.189.236]:38180 "EHLO mail.hofr.at" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752295AbbDEDhZ (ORCPT ); Sat, 4 Apr 2015 23:37:25 -0400 Date: Sun, 5 Apr 2015 05:37:22 +0200 From: Nicholas Mc Guire To: Rob Clark Cc: Nicholas Mc Guire , David Airlie , Hai Li , "dri-devel@lists.freedesktop.org" , Linux Kernel Mailing List Subject: Re: [PATCH] drm/msm: fix build warning - missing prototype Message-ID: <20150405033722.GA9842@opentech.at> References: <1428115175-1985-1-git-send-email-hofrat@osadl.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1050 Lines: 27 On Sat, 04 Apr 2015, Rob Clark wrote: > On Fri, Apr 3, 2015 at 10:39 PM, Nicholas Mc Guire wrote: > > fix build warning when building edp/edp_aux.o due to missing > > prototype for edp_aux_transfer. > > > > Signed-off-by: Nicholas Mc Guire > > --- > > building drivers/gpu/drm/msm/msm.ko gives the following warning: > > drivers/gpu/drm/msm/edp/edp_aux.c:118:9: warning: no previous prototype for 'edp_aux_transfer' [-Wmissing-prototypes] > > ssize_t edp_aux_transfer(struct drm_dp_aux *drm_aux, struct drm_dp_aux_msg *msg) > > ^ > > > > thx.. fwiw, looks like edp_aux_transfer is only used in that one > file.. so probably it actually wants to be static instead.. > yup - missed that - making it static is the cleaner solution will resend. thx! hofrat -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/