Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbbDFGmI (ORCPT ); Mon, 6 Apr 2015 02:42:08 -0400 Received: from mga01.intel.com ([192.55.52.88]:25869 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750896AbbDFGmC convert rfc822-to-8bit (ORCPT ); Mon, 6 Apr 2015 02:42:02 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,530,1422950400"; d="scan'208";a="477135546" From: "Zhen, Liang" To: Julia Lawall , "Drokin, Oleg" CC: "devel@driverdev.osuosl.org" , "Greg Kroah-Hartman" , "kernel-janitors@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "HPDD-discuss@lists.01.org" Subject: Re: [HPDD-discuss] [PATCH 15/16] staging: lustre: lnet: lnet: fix error return code Thread-Topic: [HPDD-discuss] [PATCH 15/16] staging: lustre: lnet: lnet: fix error return code Thread-Index: AQHQcDTAppdUUbWyy0KrMfT8C+l+ug== Date: Mon, 6 Apr 2015 06:41:46 +0000 Message-ID: References: <1428235596-4757-1-git-send-email-Julia.Lawall@lip6.fr> <1428235596-4757-16-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1428235596-4757-16-git-send-email-Julia.Lawall@lip6.fr> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.217.143] Content-Type: text/plain; charset="iso-8859-1" Content-ID: Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1954 Lines: 77 Julia, yes this is a bug that we have already fixed in the latest Lustre. Sorry we haven?t submitted this patch to kernel on time. Thanks Liang On 4/5/15, 8:06 PM, "Julia Lawall" wrote: >Return a negative error code on failure. > >A simplified version of the semantic match that finds this problem is as >follows: (http://coccinelle.lip6.fr/) > >// >@@ >identifier ret; expression e1,e2; >@@ >( >if (\(ret < 0\|ret != 0\)) > { ... return ret; } >| >ret = 0 >) >... when != ret = e1 > when != &ret >*if(...) >{ > ... when != ret = e2 > when forall > return ret; >} >// > >Signed-off-by: Julia Lawall > >--- > drivers/staging/lustre/lnet/lnet/api-ni.c | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/drivers/staging/lustre/lnet/lnet/api-ni.c >b/drivers/staging/lustre/lnet/lnet/api-ni.c >index faceb95..4a14e51 100644 >--- a/drivers/staging/lustre/lnet/lnet/api-ni.c >+++ b/drivers/staging/lustre/lnet/lnet/api-ni.c >@@ -650,15 +650,19 @@ lnet_prepare(lnet_pid_t requested_pid) > > recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES, > sizeof(lnet_me_t)); >- if (recs == NULL) >+ if (recs == NULL) { >+ rc = -ENOMEM; > goto failed; >+ } > > the_lnet.ln_me_containers = recs; > > recs = lnet_res_containers_create(LNET_COOKIE_TYPE_MD, LNET_FL_MAX_MDS, > sizeof(lnet_libmd_t)); >- if (recs == NULL) >+ if (recs == NULL) { >+ rc = -ENOMEM; > goto failed; >+ } > > the_lnet.ln_md_containers = recs; > > >_______________________________________________ >HPDD-discuss mailing list >HPDD-discuss@lists.01.org >https://lists.01.org/mailman/listinfo/hpdd-discuss -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/