Message-ID: <1428304366.2775.98.camel@perches.com>
Subject: Re: [PATCH 2/3] time: allow gcc to fold constants when using
 msecs_to_jiffies
From: Joe Perches <joe@perches.com>
To: Nicholas Mc Guire <der.herr@hofr.at>
Cc: Nicholas Mc Guire <hofrat@osadl.org>, Michal Marek <mmarek@suse.cz>,
        Masahiro Yamada <yamada.m@jp.panasonic.com>,
        Sam Ravnborg <sam@ravnborg.org>, Thomas Gleixner <tglx@linutronix.de>,
        "H. Peter Alvin" <hpa@zytor.com>, John Stultz <john.stultz@linaro.org>,
        Andrew Hunter <ahh@google.com>, Paul Turner <pjt@google.com>,
        linux-kernel@vger.kernel.org
Date: Mon, 06 Apr 2015 00:12:46 -0700
In-Reply-To: <20150406064005.GA32350@opentech.at>
References: <1428218636-3780-1-git-send-email-hofrat@osadl.org>
	 <1428218636-3780-3-git-send-email-hofrat@osadl.org>
	 <1428278627.2775.75.camel@perches.com> <20150406010025.GA5956@opentech.at>
	 <1428286502.2775.92.camel@perches.com> <20150406042654.GA28155@opentech.at>
	 <1428294823.2775.94.camel@perches.com> <20150406064005.GA32350@opentech.at>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1210
Lines: 45

On Mon, 2015-04-06 at 08:40 +0200, Nicholas Mc Guire wrote:
> #define msecs_to_jiffies(m)                             \
>   (__builtin_constant_p (m)                             \
>   ? ((m) * HZ / MSECS_PER_SEC ) : __msecs_to_jiffies(m))
[]
> main:
> .LFB12:
> 	.cfi_startproc
> 	subq	$8, %rsp	#,
> 	.cfi_def_cfa_offset 16
> 	movl	$10, %esi	#,
> 	movl	$.LC0, %edi	#,
> 	xorl	%eax, %eax	#
> 	call	printf	#

vs:

> static inline unsigned long msecs_to_jiffies(int m)
> {
>         return __builtin_constant_p (m) ?
>                 (m) * HZ / MSECS_PER_SEC  : __msecs_to_jiffies(m);
> }
[]
> main:
> .LFB13:
> 	.cfi_startproc
> 	subq	$8, %rsp	#,
> 	.cfi_def_cfa_offset 16
> 	xorl	%esi, %esi	#
> 	movl	$.LC0, %edi	#,
> 	xorl	%eax, %eax	#
> 	call	printf	#
> 
> giving it another run from scratch somewhere I simply screwed up or 
> overlooked some detail.

If the optimizer was doing it's job properly, wouldn't
the macro and inline output object code be the same?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/