Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753241AbbDFNF6 (ORCPT ); Mon, 6 Apr 2015 09:05:58 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:38728 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752797AbbDFNF4 (ORCPT ); Mon, 6 Apr 2015 09:05:56 -0400 MIME-Version: 1.0 In-Reply-To: References: <1427857069-6789-1-git-send-email-yinghai@kernel.org> <1427857069-6789-2-git-send-email-yinghai@kernel.org> <20150403193234.GD10892@google.com> <20150403205201.GF10892@google.com> From: Rob Herring Date: Mon, 6 Apr 2015 08:05:33 -0500 Message-ID: Subject: Re: [PATCH 1/3] PCI: Introduce pci_bus_addr_t To: Bjorn Helgaas Cc: Yinghai Lu , David Ahern , "the arch/x86 maintainers" , Russell King , "linux-mips@linux-mips.org" , "linux-pci@vger.kernel.org" , linuxppc-dev , Linux Kernel Mailing List , "stable@vger.kernel.org" , Ralf Baechle , Benjamin Herrenschmidt , "sparclinux@vger.kernel.org" , Sam Ravnborg , David Miller , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1248 Lines: 26 On Sat, Apr 4, 2015 at 10:25 PM, Bjorn Helgaas wrote: > On Sat, Apr 4, 2015 at 2:48 PM, Rob Herring wrote: >> On Sat, Apr 4, 2015 at 7:46 AM, Bjorn Helgaas wrote: > >>> I think there's still an unresolved question about the OF parsing code. >> >> Got a pointer to what that is? I'll take a guess. Generally, we make >> the parsing code independent of the kernel addr sizes and use u64 >> types. The DT sizes and kernel sizes are not always aligned. For >> example, an LPAE capable platform running a non-LPAE kernel build. > > Yep: http://lkml.kernel.org/r/1427857069-6789-3-git-send-email-yinghai@kernel.org > > Yinghai made a change to the sparc OF parsing code. The question is > whether a similar change should be made to clones of that code (two > others in arch/sparc, one in arch/powerpc, and one in drivers/of). Yes, it appears to me that is needed. At least the drivers/of/ code does not distinguish 32 and 64 bit ATM. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/