Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753110AbbDFOlG (ORCPT ); Mon, 6 Apr 2015 10:41:06 -0400 Received: from mout.kundenserver.de ([212.227.17.13]:50110 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752741AbbDFOlE convert rfc822-to-8bit (ORCPT ); Mon, 6 Apr 2015 10:41:04 -0400 From: Arnd Bergmann To: Geert Uytterhoeven Cc: Grant Likely , Rob Herring , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN Date: Mon, 06 Apr 2015 16:40:59 +0200 Message-ID: <4981781.UvXHorNsu5@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1428245965-19618-3-git-send-email-geert@linux-m68k.org> References: <1428245965-19618-1-git-send-email-geert@linux-m68k.org> <1428245965-19618-3-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" X-Provags-ID: V03:K0:OqVTiUog26/qkmLgjPJzKthhfIawleDrgcda9YehKdOXQEduojt 5jooGjGTPzEWSOkFTGFg94SA1sX9faGJac68llb66I7dlfljC9jvaIRBVh/SB74phEiSAi1 o1qyEUL/xRUeCmmdaHX4zOvBQNksNXnqwhbSiUx4Q51dNx0hPw0us/ghZUMXxhR749LjRWD W/y+Xqp5QsrCQ5EfDLwFg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 41 On Sunday 05 April 2015 16:59:24 Geert Uytterhoeven wrote: > If CONFIG_IRQ_DOMAIN=n: > > drivers/of/irq.c: In function ‘of_irq_get’: > drivers/of/irq.c:406: error: implicit declaration of function ‘irq_find_host’ > drivers/of/irq.c:406: warning: assignment makes pointer from integer without a cast > make[2]: *** [drivers/of/irq.o] Error 1 > > Signed-off-by: Geert Uytterhoeven > --- > drivers/of/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig > index 4c98f14694458794..92adecd3ecb28fc7 100644 > --- a/drivers/of/Kconfig > +++ b/drivers/of/Kconfig > @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI > > config OF_IRQ > def_bool y > - depends on !SPARC > + depends on !SPARC && IRQ_DOMAIN > > config OF_NET > depends on NETDEVICES > Sparc does not set IRQ_DOMAIN, so we can probably simplify this to config OF_IRQ def_bool IRQ_DOMAIN unless you want to keep the sparc antidependency explicit. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/