Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753177AbbDFPFm (ORCPT ); Mon, 6 Apr 2015 11:05:42 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:34952 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753047AbbDFPFk (ORCPT ); Mon, 6 Apr 2015 11:05:40 -0400 Date: Mon, 6 Apr 2015 11:05:36 -0400 From: Tejun Heo To: Aleksa Sarai Cc: lizefan@huawei.com, mingo@redhat.com, peterz@infradead.org, richard@nod.at, =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org Subject: Re: [PATCH v8 3/4] cgroups: allow a cgroup subsystem to reject a fork Message-ID: <20150406150536.GA10582@htj.duckdns.org> References: <1427878641-5273-1-git-send-email-cyphar@cyphar.com> <1427878641-5273-4-git-send-email-cyphar@cyphar.com> <20150401160258.GP9974@htj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1145 Lines: 28 Hello, Aleksa. On Fri, Apr 03, 2015 at 10:42:27AM +1100, Aleksa Sarai wrote: > I tried doing this and the kernel would refuse to boot. I believe it has > something to do with the ordering of early_init subsystems, but I'm not Hmmm... yeah, failure in early_init can be tricky to debug. > entirely sure (this optimisation can be dealt with later [it's non-critical], > so IMO this should be done in a separate patchset [if at all]). Also, your > later comments would fix the subsys bitmask problem (we can just pass the > default %NULL), we don't even need to test the index. But we'd be adding quite a few loops in relatively hot paths. I don't think it's a good idea to send the patches as-are because we can't debug and fix them properly, right? If there are hard ordering dependencies, the range of subsystems which require fork/exit doesn't have to be at the beginning. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/