Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753364AbbDFP1K (ORCPT ); Mon, 6 Apr 2015 11:27:10 -0400 Received: from mail-wg0-f52.google.com ([74.125.82.52]:36145 "EHLO mail-wg0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753325AbbDFP1F convert rfc822-to-8bit (ORCPT ); Mon, 6 Apr 2015 11:27:05 -0400 MIME-Version: 1.0 In-Reply-To: <4981781.UvXHorNsu5@wuerfel> References: <1428245965-19618-1-git-send-email-geert@linux-m68k.org> <1428245965-19618-3-git-send-email-geert@linux-m68k.org> <4981781.UvXHorNsu5@wuerfel> From: Rob Herring Date: Mon, 6 Apr 2015 10:26:43 -0500 Message-ID: Subject: Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN To: Arnd Bergmann Cc: Geert Uytterhoeven , Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1499 Lines: 45 On Mon, Apr 6, 2015 at 9:40 AM, Arnd Bergmann wrote: > On Sunday 05 April 2015 16:59:24 Geert Uytterhoeven wrote: >> If CONFIG_IRQ_DOMAIN=n: >> >> drivers/of/irq.c: In function ‘of_irq_get’: >> drivers/of/irq.c:406: error: implicit declaration of function ‘irq_find_host’ >> drivers/of/irq.c:406: warning: assignment makes pointer from integer without a cast >> make[2]: *** [drivers/of/irq.o] Error 1 >> >> Signed-off-by: Geert Uytterhoeven >> --- >> drivers/of/Kconfig | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig >> index 4c98f14694458794..92adecd3ecb28fc7 100644 >> --- a/drivers/of/Kconfig >> +++ b/drivers/of/Kconfig >> @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI >> >> config OF_IRQ >> def_bool y >> - depends on !SPARC >> + depends on !SPARC && IRQ_DOMAIN >> >> config OF_NET >> depends on NETDEVICES >> > > Sparc does not set IRQ_DOMAIN, so we can probably simplify this to > > config OF_IRQ > def_bool IRQ_DOMAIN > > unless you want to keep the sparc antidependency explicit. IRQ_DOMAIN is selected in quite a few places. We'd need to make sure none of those can be selected by Sparc. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/