Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753340AbbDFP1B (ORCPT ); Mon, 6 Apr 2015 11:27:01 -0400 Received: from mail-ob0-f172.google.com ([209.85.214.172]:33859 "EHLO mail-ob0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752791AbbDFP07 (ORCPT ); Mon, 6 Apr 2015 11:26:59 -0400 MIME-Version: 1.0 In-Reply-To: <4981781.UvXHorNsu5@wuerfel> References: <1428245965-19618-1-git-send-email-geert@linux-m68k.org> <1428245965-19618-3-git-send-email-geert@linux-m68k.org> <4981781.UvXHorNsu5@wuerfel> Date: Mon, 6 Apr 2015 17:26:57 +0200 X-Google-Sender-Auth: a7qvgFU_RXrGh6q4xtNOZU9GljI Message-ID: Subject: Re: [PATCH 2/3] of: OF_IRQ should depend on IRQ_DOMAIN From: Geert Uytterhoeven To: Arnd Bergmann Cc: Grant Likely , Rob Herring , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1437 Lines: 55 Hi Arnd, On Mon, Apr 6, 2015 at 4:40 PM, Arnd Bergmann wrote: >> --- a/drivers/of/Kconfig >> +++ b/drivers/of/Kconfig >> @@ -50,7 +50,7 @@ config OF_ADDRESS_PCI >> >> config OF_IRQ >> def_bool y >> - depends on !SPARC >> + depends on !SPARC && IRQ_DOMAIN >> >> config OF_NET >> depends on NETDEVICES >> > > Sparc does not set IRQ_DOMAIN, so we can probably simplify this to > > config OF_IRQ > def_bool IRQ_DOMAIN > > unless you want to keep the sparc antidependency explicit. Given drivers/base/platform.c: int platform_get_irq(struct platform_device *dev, unsigned int num) { #ifdef CONFIG_SPARC ... #else struct resource *r; if (IS_ENABLED(CONFIG_OF_IRQ) && dev->dev.of_node) { ... } ... #endif } yes I do want to keep it explicit. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/