Date: Mon, 6 Apr 2015 11:39:21 -0400
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <cl@linux.com>,
        Kevin Hilman <khilman@linaro.org>,
        Mike Galbraith <bitbucket@online.de>,
        "Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
        Viresh Kumar <viresh.kumar@linaro.org>,
        Frederic Weisbecker <fweisbec@gmail.com>
Subject: Re: [PATCH 2/4 V6] workqueue: split apply_workqueue_attrs() into 3
 stages
Message-ID: <20150406153921.GC10582@htj.duckdns.org>
References: <1426653617-3240-1-git-send-email-laijs@cn.fujitsu.com>
 <1427973282-3052-1-git-send-email-laijs@cn.fujitsu.com>
 <1427973282-3052-3-git-send-email-laijs@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1427973282-3052-3-git-send-email-laijs@cn.fujitsu.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 799
Lines: 20

On Thu, Apr 02, 2015 at 07:14:40PM +0800, Lai Jiangshan wrote:
> The patch doesn't have functionality changed except two minor adjustment:
> 	1) free_unbound_pwq() for the error path is removed, we use the
> 	   heavier version put_pwq_unlocked() instead since the error path
> 	   is rare. this adjustment simplifies the code.
> 	2) the memory-allocation is also moved into wq_pool_mutex.
> 	   this is needed to avoid to do the further splitting.

And we're dropping online_cpus locking before applying the new pwq's.
Is that safe?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/