Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753160AbbDFRro (ORCPT ); Mon, 6 Apr 2015 13:47:44 -0400 Received: from g1t5424.austin.hp.com ([15.216.225.54]:46514 "EHLO g1t5424.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753088AbbDFRrk (ORCPT ); Mon, 6 Apr 2015 13:47:40 -0400 Message-ID: <1428341356.31093.133.camel@misato.fc.hp.com> Subject: Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type From: Toshi Kani To: Ingo Molnar Cc: Yinghai Lu , Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List , the arch/x86 maintainers , Jens Axboe Date: Mon, 06 Apr 2015 11:29:16 -0600 In-Reply-To: <20150404094054.GA21027@gmail.com> References: <1427872339-6688-1-git-send-email-hch@lst.de> <1427872339-6688-2-git-send-email-hch@lst.de> <1428077687.31093.120.camel@misato.fc.hp.com> <1428094444.31093.122.camel@misato.fc.hp.com> <20150404094054.GA21027@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2149 Lines: 52 On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: > * Toshi Kani wrote: > > > On Fri, 2015-04-03 at 10:12 -0700, Yinghai Lu wrote: > > > On Fri, Apr 3, 2015 at 9:14 AM, Toshi Kani wrote: > > > > On Wed, 2015-04-01 at 09:12 +0200, Christoph Hellwig wrote: > > > > : > > > >> @@ -748,7 +758,7 @@ u64 __init early_reserve_e820(u64 size, u64 align) > > > >> /* > > > >> * Find the highest page frame number we have available > > > >> */ > > > >> -static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type) > > > >> +static unsigned long __init e820_end_pfn(unsigned long limit_pfn) > > > >> { > > > >> int i; > > > >> unsigned long last_pfn = 0; > > > >> @@ -759,7 +769,11 @@ static unsigned long __init e820_end_pfn(unsigned long limit_pfn, unsigned type) > > > >> unsigned long start_pfn; > > > >> unsigned long end_pfn; > > > >> > > > >> - if (ei->type != type) > > > >> + /* > > > >> + * Persistent memory is accounted as ram for purposes of > > > >> + * establishing max_pfn and mem_map. > > > >> + */ > > > >> + if (ei->type != E820_RAM && ei->type != E820_PRAM) > > > >> continue; > > > > > > > > Should we also delete this code, accounting E820_PRAM as ram, along with > > > > the deletion of reserve_pmem() in this version? > > > > > > should revert those end_of_ram change as attached. > > > > I confirmed that the pmem driver works with the change, and last_pfn is > > updated as expected. > > Could someone please send the fix with a changelog, etc? OK, I will send a patch for the fix, with suggested update from Christoph of not to re-add 'type' argument to e820_end_pfn(). Yinghai, I will add your sign-off to the patch. Let me know if you have any concern. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/