Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753223AbbDFSla (ORCPT ); Mon, 6 Apr 2015 14:41:30 -0400 Received: from g1t5424.austin.hp.com ([15.216.225.54]:41595 "EHLO g1t5424.austin.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752962AbbDFSl3 (ORCPT ); Mon, 6 Apr 2015 14:41:29 -0400 X-Greylist: delayed 3229 seconds by postgrey-1.27 at vger.kernel.org; Mon, 06 Apr 2015 14:41:29 EDT Message-ID: <1428344585.31093.136.camel@misato.fc.hp.com> Subject: Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard protected e820 type From: Toshi Kani To: Yinghai Lu Cc: Ingo Molnar , Christoph Hellwig , linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org, Linux Kernel Mailing List , the arch/x86 maintainers , Jens Axboe Date: Mon, 06 Apr 2015 12:23:05 -0600 In-Reply-To: References: <1427872339-6688-1-git-send-email-hch@lst.de> <1427872339-6688-2-git-send-email-hch@lst.de> <1428077687.31093.120.camel@misato.fc.hp.com> <1428094444.31093.122.camel@misato.fc.hp.com> <20150404094054.GA21027@gmail.com> <1428341356.31093.133.camel@misato.fc.hp.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 30 On Mon, 2015-04-06 at 11:26 -0700, Yinghai Lu wrote: > On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani wrote: > > On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote: > > > OK, I will send a patch for the fix, with suggested update from > > Christoph of not to re-add 'type' argument to e820_end_pfn(). > > > > Yinghai, I will add your sign-off to the patch. Let me know if you have > > any concern. > > I think we should restore all to original. > > e820_end_pfn(unsigned long limit_pfn, unsigned type) > e820_end_of_ram_pfn > e820_end_of_low_ram_pfn > > otherwise it will cause confusing, because last two really have ram_pfn, > and the first one does not has ram in the function name. Good point. I will revert back to the original. Thanks, -Toshi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/