MIME-Version: 1.0
In-Reply-To: <1428341356.31093.133.camel@misato.fc.hp.com>
References: <1427872339-6688-1-git-send-email-hch@lst.de>
	<1427872339-6688-2-git-send-email-hch@lst.de>
	<1428077687.31093.120.camel@misato.fc.hp.com>
	<CAE9FiQXg0DZ3oCGmPk+qubwQ_=9LLMrZTJqN6HPn0t+5Vs8+Jg@mail.gmail.com>
	<1428094444.31093.122.camel@misato.fc.hp.com>
	<20150404094054.GA21027@gmail.com>
	<1428341356.31093.133.camel@misato.fc.hp.com>
Date: Mon, 6 Apr 2015 11:26:35 -0700
Message-ID: <CAE9FiQXshnMX5RnTGEydR=MOeioE_EbutYLt0FWn1LOofREJoQ@mail.gmail.com>
Subject: Re: [Linux-nvdimm] [PATCH 1/2] x86: add support for the non-standard
 protected e820 type
From: Yinghai Lu <yinghai@kernel.org>
To: Toshi Kani <toshi.kani@hp.com>
Cc: Ingo Molnar <mingo@kernel.org>, Christoph Hellwig <hch@lst.de>,
        linux-nvdimm@ml01.01.org, linux-fsdevel@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        "the arch/x86 maintainers" <x86@kernel.org>,
        Jens Axboe <axboe@kernel.dk>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 885
Lines: 26

On Mon, Apr 6, 2015 at 10:29 AM, Toshi Kani <toshi.kani@hp.com> wrote:
> On Sat, 2015-04-04 at 11:40 +0200, Ingo Molnar wrote:

> OK, I will send a patch for the fix, with suggested update from
> Christoph of not to re-add 'type' argument to e820_end_pfn().
>
> Yinghai, I will add your sign-off to the patch.  Let me know if you have
> any concern.

I think we should restore all to original.

e820_end_pfn(unsigned long limit_pfn, unsigned type)
e820_end_of_ram_pfn
e820_end_of_low_ram_pfn

otherwise it will cause confusing, because last two really have ram_pfn,
and the first one does not has ram in the function name.

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/